Linux Kernel Selftest development
 help / color / mirror / Atom feed
* [PATCH] selftest/powerpc/pmu/ebb: remove fixed_instruction.S
@ 2022-03-22  4:56 Madhavan Srinivasan
  2022-05-24 11:09 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Madhavan Srinivasan @ 2022-03-22  4:56 UTC (permalink / raw)
  To: mpe
  Cc: shuah, kjain, atrajeev, linuxppc-dev, linux-kselftest,
	Madhavan Srinivasan

Commit 3752e453f6ba ("selftests/powerpc: Add tests of PMU EBBs") added
selftest testcases to verify EBB interface. instruction_count_test.c
testcase needs a fixed loop function to count overhead. Instead of
using the thirty_two_instruction_loop() in fixed_instruction_loop.S
in ebb folder, file is linked with thirty_two_instruction_loop() in
loop.S from top folder. Since fixed_instruction_loop.S not used, patch
removes the file.

Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
---
 .../powerpc/pmu/ebb/fixed_instruction_loop.S  | 43 -------------------
 1 file changed, 43 deletions(-)
 delete mode 100644 tools/testing/selftests/powerpc/pmu/ebb/fixed_instruction_loop.S

diff --git a/tools/testing/selftests/powerpc/pmu/ebb/fixed_instruction_loop.S b/tools/testing/selftests/powerpc/pmu/ebb/fixed_instruction_loop.S
deleted file mode 100644
index 08a7b5f133b9..000000000000
--- a/tools/testing/selftests/powerpc/pmu/ebb/fixed_instruction_loop.S
+++ /dev/null
@@ -1,43 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * Copyright 2014, Michael Ellerman, IBM Corp.
- */
-
-#include <ppc-asm.h>
-
-	.text
-
-FUNC_START(thirty_two_instruction_loop)
-	cmpwi	r3,0
-	beqlr
-	addi	r4,r3,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1
-	addi	r4,r4,1	# 28 addi's
-	subi	r3,r3,1
-	b	FUNC_NAME(thirty_two_instruction_loop)
-FUNC_END(thirty_two_instruction_loop)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftest/powerpc/pmu/ebb: remove fixed_instruction.S
  2022-03-22  4:56 [PATCH] selftest/powerpc/pmu/ebb: remove fixed_instruction.S Madhavan Srinivasan
@ 2022-05-24 11:09 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2022-05-24 11:09 UTC (permalink / raw)
  To: Madhavan Srinivasan, mpe
  Cc: kjain, shuah, linux-kselftest, atrajeev, linuxppc-dev

On Tue, 22 Mar 2022 10:26:38 +0530, Madhavan Srinivasan wrote:
> Commit 3752e453f6ba ("selftests/powerpc: Add tests of PMU EBBs") added
> selftest testcases to verify EBB interface. instruction_count_test.c
> testcase needs a fixed loop function to count overhead. Instead of
> using the thirty_two_instruction_loop() in fixed_instruction_loop.S
> in ebb folder, file is linked with thirty_two_instruction_loop() in
> loop.S from top folder. Since fixed_instruction_loop.S not used, patch
> removes the file.
> 
> [...]

Applied to powerpc/next.

[1/1] selftest/powerpc/pmu/ebb: remove fixed_instruction.S
      https://git.kernel.org/powerpc/c/079e5fd3a1e41c186c1bc4166d409d22e70729bf

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-24 11:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-22  4:56 [PATCH] selftest/powerpc/pmu/ebb: remove fixed_instruction.S Madhavan Srinivasan
2022-05-24 11:09 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox