[PATCH] selftests: x86: add 32bit build warnings for SUSE

[PATCH] selftests: x86: add 32bit build warnings for SUSE

[Geliang Tang]

In order to successfully build all these 32bit tests, these 32bit gcc
and glibc packages, named gcc-32bit and glibc-devel-static-32bit on SUSE,
need to be installed.

This patch added this information in warn_32bit_failure.

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/x86/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index 8a1f62ab3c8e..ffd7c1fa2c9e 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -92,6 +92,10 @@ warn_32bit_failure:
 	echo "If you are using a Fedora-like distribution, try:";	\
 	echo "";							\
 	echo "  yum install glibc-devel.*i686";				\
+	echo "";							\
+	echo "If you are using a SUSE-like distribution, try:";		\
+	echo "";							\
+	echo "  zypper install gcc-32bit glibc-devel-static-32bit";	\
 	exit 0;
 endif
 
-- 
2.34.1

Re: [PATCH] selftests: x86: add 32bit build warnings for SUSE

[Shuah Khan]

On 3/24/22 3:55 AM, Geliang Tang wrote:
> In order to successfully build all these 32bit tests, these 32bit gcc
> and glibc packages, named gcc-32bit and glibc-devel-static-32bit on SUSE,
> need to be installed.
> 
> This patch added this information in warn_32bit_failure.
> 

Convention is to use "This patch adds" i.e  imperative, present tense
in commit logs.

I will amend the commit log when applying. Please keep that in mind for
future patches.

> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
>   tools/testing/selftests/x86/Makefile | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
> index 8a1f62ab3c8e..ffd7c1fa2c9e 100644
> --- a/tools/testing/selftests/x86/Makefile
> +++ b/tools/testing/selftests/x86/Makefile
> @@ -92,6 +92,10 @@ warn_32bit_failure:
>   	echo "If you are using a Fedora-like distribution, try:";	\
>   	echo "";							\
>   	echo "  yum install glibc-devel.*i686";				\
> +	echo "";							\
> +	echo "If you are using a SUSE-like distribution, try:";		\
> +	echo "";							\
> +	echo "  zypper install gcc-32bit glibc-devel-static-32bit";	\
>   	exit 0;
>   endif
>   
> 

Thank you for the patch. Will apply for Linux 5.18-rc2

thanks,
-- Shuah

Re: [PATCH] selftests: x86: add 32bit build warnings for SUSE

[Geliang Tang]

On Fri, Mar 25, 2022 at 01:45:13PM -0600, Shuah Khan wrote:
> On 3/24/22 3:55 AM, Geliang Tang wrote:
> > In order to successfully build all these 32bit tests, these 32bit gcc
> > and glibc packages, named gcc-32bit and glibc-devel-static-32bit on SUSE,
> > need to be installed.
> > 
> > This patch added this information in warn_32bit_failure.
> > 
> 
> Convention is to use "This patch adds" i.e  imperative, present tense
> in commit logs.
> 
> I will amend the commit log when applying. Please keep that in mind for
> future patches.

Thank you so much for your reminder. It seems that I have used the wrong
tense in the commit logs for several years. I will use the present tense
as you suggest in future patches.

Thanks,
-Geliang

> 
> > Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> > ---
> >   tools/testing/selftests/x86/Makefile | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
> > index 8a1f62ab3c8e..ffd7c1fa2c9e 100644
> > --- a/tools/testing/selftests/x86/Makefile
> > +++ b/tools/testing/selftests/x86/Makefile
> > @@ -92,6 +92,10 @@ warn_32bit_failure:
> >   	echo "If you are using a Fedora-like distribution, try:";	\
> >   	echo "";							\
> >   	echo "  yum install glibc-devel.*i686";				\
> > +	echo "";							\
> > +	echo "If you are using a SUSE-like distribution, try:";		\
> > +	echo "";							\
> > +	echo "  zypper install gcc-32bit glibc-devel-static-32bit";	\
> >   	exit 0;
> >   endif
> > 
> 
> Thank you for the patch. Will apply for Linux 5.18-rc2
> 
> thanks,
> -- Shuah
>