From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
Shuah Khan <shuah@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org,
Mark Brown <broonie@kernel.org>
Subject: [PATCH v2 4/6] kselftest/alsa: Don't any configuration in the sample config
Date: Thu, 1 Dec 2022 17:07:43 +0000 [thread overview]
Message-ID: <20221201170745.1111236-5-broonie@kernel.org> (raw)
In-Reply-To: <20221201170745.1111236-1-broonie@kernel.org>
The values in the one example configuration file we currently have are the
default values for the two tests we have so there's no need to actually set
them. Comment them out as examples, with a rename for the tests so that we
can update the tests in the code more easily.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
.../alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf | 35 ++++++++++---------
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/tools/testing/selftests/alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf b/tools/testing/selftests/alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf
index 0a83f35d43eb..9eca985e0c08 100644
--- a/tools/testing/selftests/alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf
+++ b/tools/testing/selftests/alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf
@@ -39,22 +39,25 @@ card.hda {
#
pcm.0.0 {
PLAYBACK {
- test.time1 {
- access RW_INTERLEAVED # can be omitted - default
- format S16_LE # can be omitted - default
- rate 48000 # can be omitted - default
- channels 2 # can be omitted - default
- period_size 512
- buffer_size 4096
- }
- test.time2 {
- access RW_INTERLEAVED
- format S16_LE
- rate 48000
- channels 2
- period_size 24000
- buffer_size 192000
- }
+ #
+ # Uncomment to override values for specific tests
+ #
+ #test_name1 {
+ # access RW_INTERLEAVED
+ # format S16_LE
+ # rate 48000
+ # channels 2
+ # period_size 512
+ # buffer_size 4096
+ #}
+ #test_name2 {
+ # access RW_INTERLEAVED
+ # format S16_LE
+ # rate 48000
+ # channels 2
+ # period_size 24000
+ # buffer_size 192000
+ #}
}
CAPTURE {
# use default tests, check for the presence
--
2.30.2
next prev parent reply other threads:[~2022-12-01 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 17:07 [PATCH v2 0/6] kselftest/alsa: pcm-test improvements Mark Brown
2022-12-01 17:07 ` [PATCH v2 1/6] kselftest/alsa: Refactor pcm-test to list the tests to run in a struct Mark Brown
2022-12-01 17:07 ` [PATCH v2 2/6] kselftest/alsa: Report failures to set the requested sample rate as skips Mark Brown
2022-12-01 17:07 ` [PATCH v2 3/6] kselftest/alsa: Report failures to set the requested channels " Mark Brown
2022-12-01 17:07 ` Mark Brown [this message]
2022-12-01 17:07 ` [PATCH v2 5/6] kselftest/alsa: Provide more meaningful names for tests Mark Brown
2022-12-01 17:07 ` [PATCH v2 6/6] kselftest/alsa: Add more coverage of sample rates and channel counts Mark Brown
2022-12-01 19:06 ` [PATCH v2 0/6] kselftest/alsa: pcm-test improvements Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201170745.1111236-5-broonie@kernel.org \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox