From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
Shuah Khan <shuah@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org,
Mark Brown <broonie@kernel.org>
Subject: [PATCH v2 5/6] kselftest/alsa: Provide more meaningful names for tests
Date: Thu, 1 Dec 2022 17:07:44 +0000 [thread overview]
Message-ID: <20221201170745.1111236-6-broonie@kernel.org> (raw)
In-Reply-To: <20221201170745.1111236-1-broonie@kernel.org>
Rather than just numbering the tests try to provide semi descriptive names
for what the tests are trying to cover. This also has the advantage of
meaning we can add more tests without having to keep the list of tests
ordered by existing number which should make it easier to understand what
we're testing and why.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
tools/testing/selftests/alsa/pcm-test.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/alsa/pcm-test.c b/tools/testing/selftests/alsa/pcm-test.c
index c701cf507a95..afa13377481d 100644
--- a/tools/testing/selftests/alsa/pcm-test.c
+++ b/tools/testing/selftests/alsa/pcm-test.c
@@ -446,9 +446,9 @@ static void test_pcm_time1(struct pcm_data *data,
}
static const struct time_test_def time_tests[] = {
- /* name format rate chan period buffer */
- { "test.time1", "S16_LE", 48000, 2, 512, 4096 },
- { "test.time2", "S16_LE", 48000, 2, 24000, 192000 },
+ /* name format rate chan period buffer */
+ { "S16.48k.2.small", "S16_LE", 48000, 2, 512, 4096 },
+ { "S16.48k.2.big", "S16_LE", 48000, 2, 24000, 192000 },
};
int main(void)
--
2.30.2
next prev parent reply other threads:[~2022-12-01 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 17:07 [PATCH v2 0/6] kselftest/alsa: pcm-test improvements Mark Brown
2022-12-01 17:07 ` [PATCH v2 1/6] kselftest/alsa: Refactor pcm-test to list the tests to run in a struct Mark Brown
2022-12-01 17:07 ` [PATCH v2 2/6] kselftest/alsa: Report failures to set the requested sample rate as skips Mark Brown
2022-12-01 17:07 ` [PATCH v2 3/6] kselftest/alsa: Report failures to set the requested channels " Mark Brown
2022-12-01 17:07 ` [PATCH v2 4/6] kselftest/alsa: Don't any configuration in the sample config Mark Brown
2022-12-01 17:07 ` Mark Brown [this message]
2022-12-01 17:07 ` [PATCH v2 6/6] kselftest/alsa: Add more coverage of sample rates and channel counts Mark Brown
2022-12-01 19:06 ` [PATCH v2 0/6] kselftest/alsa: pcm-test improvements Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201170745.1111236-6-broonie@kernel.org \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox