Linux Kernel Selftest development
 help / color / mirror / Atom feed
* [PATCH net] net: selftests: Fix optstring
@ 2023-05-16 18:49 Benjamin Poirier
  2023-05-17 12:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Poirier @ 2023-05-16 18:49 UTC (permalink / raw)
  To: netdev; +Cc: Amit Cohen, linux-kselftest, Ido Schimmel

The cited commit added a stray colon to the 'v' option. That makes the
option work incorrectly.

ex:
tools/testing/selftests/net# ./fib_nexthops.sh -v
(should enable verbose mode, instead it shows help text due to missing arg)

Fixes: 5feba4727395 ("selftests: fib_nexthops: Make ping timeout configurable")
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
---
 tools/testing/selftests/net/fib_nexthops.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh
index a47b26ab48f2..0f5e88c8f4ff 100755
--- a/tools/testing/selftests/net/fib_nexthops.sh
+++ b/tools/testing/selftests/net/fib_nexthops.sh
@@ -2283,7 +2283,7 @@ EOF
 ################################################################################
 # main
 
-while getopts :t:pP46hv:w: o
+while getopts :t:pP46hvw: o
 do
 	case $o in
 		t) TESTS=$OPTARG;;
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: selftests: Fix optstring
  2023-05-16 18:49 [PATCH net] net: selftests: Fix optstring Benjamin Poirier
@ 2023-05-17 12:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-05-17 12:10 UTC (permalink / raw)
  To: Benjamin Poirier; +Cc: netdev, amcohen, linux-kselftest, idosch

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue, 16 May 2023 14:49:24 -0400 you wrote:
> The cited commit added a stray colon to the 'v' option. That makes the
> option work incorrectly.
> 
> ex:
> tools/testing/selftests/net# ./fib_nexthops.sh -v
> (should enable verbose mode, instead it shows help text due to missing arg)
> 
> [...]

Here is the summary with links:
  - [net] net: selftests: Fix optstring
    https://git.kernel.org/netdev/net/c/9ba9485b87ac

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-17 12:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-16 18:49 [PATCH net] net: selftests: Fix optstring Benjamin Poirier
2023-05-17 12:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox