Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
	Peter Xu <peterx@redhat.com>, "Shuah Khan" <shuah@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>, <linux-mm@kvack.org>,
	<linux-kselftest@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH 09/12] selftests/mm: move psize(), pshift() into vm_utils.c
Date: Thu, 1 Jun 2023 18:33:55 -0700	[thread overview]
Message-ID: <20230602013358.900637-10-jhubbard@nvidia.com> (raw)
In-Reply-To: <20230602013358.900637-1-jhubbard@nvidia.com>

This is in preparation for linking test programs with both vm_utils.c
and uffd-common.c. The static inline routines would prevent that, and
there is no particular need for inlining here, so turn these into normal
functions that are more flexible to build and link.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/mm/vm_util.c | 14 ++++++++++++++
 tools/testing/selftests/mm/vm_util.h | 16 ++--------------
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/tools/testing/selftests/mm/vm_util.c b/tools/testing/selftests/mm/vm_util.c
index 9b06a5034808..01296c17df02 100644
--- a/tools/testing/selftests/mm/vm_util.c
+++ b/tools/testing/selftests/mm/vm_util.c
@@ -301,3 +301,17 @@ int uffd_get_features(uint64_t *features)
 
 	return 0;
 }
+
+unsigned int psize(void)
+{
+	if (!__page_size)
+		__page_size = sysconf(_SC_PAGESIZE);
+	return __page_size;
+}
+
+unsigned int pshift(void)
+{
+	if (!__page_shift)
+		__page_shift = (ffsl(psize()) - 1);
+	return __page_shift;
+}
diff --git a/tools/testing/selftests/mm/vm_util.h b/tools/testing/selftests/mm/vm_util.h
index b950bd16083a..232ffeb5805c 100644
--- a/tools/testing/selftests/mm/vm_util.h
+++ b/tools/testing/selftests/mm/vm_util.h
@@ -3,7 +3,6 @@
 #include <stdbool.h>
 #include <sys/mman.h>
 #include <err.h>
-#include <string.h> /* ffsl() */
 #include <unistd.h> /* _SC_PAGESIZE */
 
 #define BIT_ULL(nr)                   (1ULL << (nr))
@@ -17,19 +16,8 @@
 extern unsigned int __page_size;
 extern unsigned int __page_shift;
 
-static inline unsigned int psize(void)
-{
-	if (!__page_size)
-		__page_size = sysconf(_SC_PAGESIZE);
-	return __page_size;
-}
-
-static inline unsigned int pshift(void)
-{
-	if (!__page_shift)
-		__page_shift = (ffsl(psize()) - 1);
-	return __page_shift;
-}
+unsigned int psize(void);
+unsigned int pshift(void);
 
 uint64_t pagemap_get_entry(int fd, char *start);
 bool pagemap_is_softdirty(int fd, char *start);
-- 
2.40.1


  parent reply	other threads:[~2023-06-02  1:35 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02  1:33 [PATCH 00/12] A minor flurry of selftest/mm fixes John Hubbard
2023-06-02  1:33 ` [PATCH 01/12] selftests/mm: fix uffd-stress unused function warning John Hubbard
2023-06-02  9:58   ` David Hildenbrand
2023-06-02 15:25   ` Peter Xu
2023-06-02  1:33 ` [PATCH 02/12] selftests/mm: fix unused variable warning in hugetlb-madvise.c John Hubbard
2023-06-02 10:01   ` David Hildenbrand
2023-06-02 18:38     ` John Hubbard
2023-06-02  1:33 ` [PATCH 03/12] selftests/mm: fix unused variable warning in migration.c John Hubbard
2023-06-02 10:02   ` David Hildenbrand
2023-06-02 18:39     ` John Hubbard
2023-06-02  1:33 ` [PATCH 04/12] selftests/mm: fix a char* assignment in mlock2-tests.c John Hubbard
2023-06-02 10:04   ` David Hildenbrand
2023-06-02 15:24     ` Peter Xu
2023-06-02 18:52       ` John Hubbard
2023-06-05 15:38         ` Peter Xu
2023-06-05 18:45           ` John Hubbard
2023-06-02  1:33 ` [PATCH 05/12] selftests/mm: fix invocation of tests that are run via shell scripts John Hubbard
2023-06-02 10:05   ` David Hildenbrand
2023-06-02 20:38     ` John Hubbard
2023-06-02 15:34   ` Peter Xu
2023-06-02 19:19     ` John Hubbard
2023-06-02 21:36       ` Peter Xu
2023-06-02 21:46         ` John Hubbard
2023-06-02  1:33 ` [PATCH 06/12] selftests/mm: .gitignore: add mkdirty, va_high_addr_switch John Hubbard
2023-06-02 10:06   ` David Hildenbrand
2023-06-02  1:33 ` [PATCH 07/12] selftests/mm: set -Wno-format-security to avoid uffd build warnings John Hubbard
2023-06-02 10:15   ` David Hildenbrand
2023-06-02 21:22     ` John Hubbard
2023-06-02  1:33 ` [PATCH 08/12] selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h John Hubbard
2023-06-02 10:16   ` David Hildenbrand
2023-06-02  1:33 ` John Hubbard [this message]
2023-06-02 10:19   ` [PATCH 09/12] selftests/mm: move psize(), pshift() into vm_utils.c David Hildenbrand
2023-06-02 21:58     ` John Hubbard
2023-06-02  1:33 ` [PATCH 10/12] selftests/mm: move uffd* routines from vm_util.c to uffd-common.c John Hubbard
2023-06-02 15:59   ` Peter Xu
2023-06-02 22:11     ` John Hubbard
2023-06-02 22:38       ` Peter Xu
2023-06-02 22:52         ` John Hubbard
2023-06-03  0:43           ` John Hubbard
2023-06-03  1:18             ` Peter Xu
2023-06-03  1:39               ` John Hubbard
2023-06-02  1:33 ` [PATCH 11/12] selftests/mm: fix missing UFFDIO_CONTINUE_MODE_WP and similar build failures John Hubbard
2023-06-02 10:23   ` David Hildenbrand
2023-06-02 22:20     ` John Hubbard
2023-06-03  8:27       ` David Hildenbrand
2023-06-03 23:48         ` John Hubbard
2023-06-02 16:25   ` Muhammad Usama Anjum
2023-06-02 22:24     ` John Hubbard
2023-06-02  1:33 ` [PATCH 12/12] selftests/mm: fix uffd-unit-tests.c build failure due to missing MADV_COLLAPSE John Hubbard
2023-06-02 10:23   ` David Hildenbrand
2023-06-02 16:34   ` Muhammad Usama Anjum
2023-06-02 22:26     ` John Hubbard
2023-06-02  9:32 ` [PATCH 00/12] A minor flurry of selftest/mm fixes David Hildenbrand
2023-06-02 17:51   ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230602013358.900637-10-jhubbard@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nathan@kernel.org \
    --cc=peterx@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox