From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-kselftest@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>,
Shuah Khan <shuah@kernel.org>,
Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
linux-kernel@vger.kernel.org
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v5 05/19] selftests/resctrl: Unmount resctrl FS before starting the first test
Date: Mon, 17 Jul 2023 16:14:53 +0300 [thread overview]
Message-ID: <20230717131507.32420-6-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230717131507.32420-1-ilpo.jarvinen@linux.intel.com>
Resctrl FS mount/remount/umount code is hard to track. Better approach
is to use mount/umount pair for each test but that assumes resctrl FS
is not mounted beforehand.
Change umount_resctrlfs() so that it can unmount resctrl FS from any
path, and enable further simplifications into mount/remount/umount
logic by unmounting resctrl FS at the start if a pre-existing
mountpoint is found.
Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
tools/testing/selftests/resctrl/resctrl_tests.c | 3 +++
tools/testing/selftests/resctrl/resctrlfs.c | 10 ++++++++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index 9b9751206e1c..61c3882a26c8 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -250,6 +250,9 @@ int main(int argc, char **argv)
if (!check_resctrlfs_support())
return ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL config option.\n");
+ if (umount_resctrlfs())
+ return ksft_exit_skip("resctrl FS unmount failed.\n");
+
filter_dmesg();
ksft_set_plan(tests ? : 4);
diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
index fb00245dee92..cf0c8dd34b8b 100644
--- a/tools/testing/selftests/resctrl/resctrlfs.c
+++ b/tools/testing/selftests/resctrl/resctrlfs.c
@@ -82,10 +82,16 @@ int remount_resctrlfs(bool mum_resctrlfs)
int umount_resctrlfs(void)
{
- if (find_resctrl_mount(NULL))
+ char mountpoint[256];
+ int ret;
+
+ ret = find_resctrl_mount(mountpoint);
+ if (ret == -ENOENT)
return 0;
+ if (ret)
+ return ret;
- if (umount(RESCTRL_PATH)) {
+ if (umount(mountpoint)) {
perror("# Unable to umount resctrl");
return errno;
--
2.30.2
next prev parent reply other threads:[~2023-07-17 13:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 13:14 [PATCH v5 00/19] selftests/resctrl: Fixes and cleanups Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 01/19] selftests/resctrl: Add resctrl.h into build deps Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 02/19] selftests/resctrl: Don't leak buffer in fill_cache() Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 03/19] selftests/resctrl: Unmount resctrl FS if child fails to run benchmark Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 04/19] selftests/resctrl: Close perf value read fd on errors Ilpo Järvinen
2023-07-25 15:26 ` Reinette Chatre
2023-07-17 13:14 ` Ilpo Järvinen [this message]
2023-07-17 13:14 ` [PATCH v5 06/19] selftests/resctrl: Move resctrl FS mount/umount to higher level Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 07/19] selftests/resctrl: Refactor remount_resctrl(bool mum_resctrlfs) to mount_resctrl() Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 08/19] selftests/resctrl: Remove mum_resctrlfs from struct resctrl_val_param Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 09/19] selftests/resctrl: Convert span to size_t Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 10/19] selftests/resctrl: Express span internally in bytes Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 11/19] selftests/resctrl: Remove duplicated preparation for span arg Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 12/19] selftests/resctrl: Remove "malloc_and_init_memory" param from run_fill_buf() Ilpo Järvinen
2023-07-25 14:49 ` Shuah Khan
2023-07-25 15:26 ` Reinette Chatre
2023-08-07 10:21 ` Ilpo Järvinen
2023-08-07 18:47 ` Shuah Khan
2023-08-07 19:02 ` Reinette Chatre
2023-07-17 13:15 ` [PATCH v5 13/19] selftests/resctrl: Remove unnecessary startptr global from fill_buf Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 14/19] selftests/resctrl: Improve parameter consistency in fill_buf Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 15/19] selftests/resctrl: Don't pass test name to fill_buf Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 16/19] selftests/resctrl: Don't use variable argument list for ->setup() Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 17/19] selftests/resctrl: Move CAT/CMT test global vars to function they are used in Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 18/19] selftests/resctrl: Pass the real number of tests to show_cache_info() Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 19/19] selftests/resctrl: Remove test type checks from cat_val() Ilpo Järvinen
2023-07-17 15:11 ` [PATCH v5 00/19] selftests/resctrl: Fixes and cleanups Babu Moger
2023-07-18 6:47 ` Shaopeng Tan (Fujitsu)
2023-07-25 14:55 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717131507.32420-6-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox