From: Shuah Khan <skhan@linuxfoundation.org>
To: "Reinette Chatre" <reinette.chatre@intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kselftest@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
"Fenghua Yu" <fenghua.yu@intel.com>,
"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
linux-kernel@vger.kernel.org,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH v5 12/19] selftests/resctrl: Remove "malloc_and_init_memory" param from run_fill_buf()
Date: Mon, 7 Aug 2023 12:47:18 -0600 [thread overview]
Message-ID: <dd320704-a923-2e0e-a8ed-0693d294ee33@linuxfoundation.org> (raw)
In-Reply-To: <856ad175-26f8-90ea-d801-c722d2b19b2e@intel.com>
On 7/25/23 09:26, Reinette Chatre wrote:
> Hi Shuah,
>
> On 7/25/2023 7:49 AM, Shuah Khan wrote:
>> WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
>> #233: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:276:
>> + strcpy(benchmark_cmd[3], "0");
>>
>> WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
>> #234: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:277:
>> + strcpy(benchmark_cmd[4], "");
>>
>> total: 0 errors, 2 warnings, 142 lines checked
>>
>> I am applying the patch set to linux-kselftest next - please fix
>> the aboe and send a patch on top of linux-kselftest next
>
> Is strscpy() available to userspace? I found lib/strscpy_kunit.c
> that makes me think this is currently only available to kernel code.
>
Very likely. You can ignore the comment. I already applied the
series anyway.
thanks,
-- Shuah
next prev parent reply other threads:[~2023-08-07 18:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 13:14 [PATCH v5 00/19] selftests/resctrl: Fixes and cleanups Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 01/19] selftests/resctrl: Add resctrl.h into build deps Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 02/19] selftests/resctrl: Don't leak buffer in fill_cache() Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 03/19] selftests/resctrl: Unmount resctrl FS if child fails to run benchmark Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 04/19] selftests/resctrl: Close perf value read fd on errors Ilpo Järvinen
2023-07-25 15:26 ` Reinette Chatre
2023-07-17 13:14 ` [PATCH v5 05/19] selftests/resctrl: Unmount resctrl FS before starting the first test Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 06/19] selftests/resctrl: Move resctrl FS mount/umount to higher level Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 07/19] selftests/resctrl: Refactor remount_resctrl(bool mum_resctrlfs) to mount_resctrl() Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 08/19] selftests/resctrl: Remove mum_resctrlfs from struct resctrl_val_param Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 09/19] selftests/resctrl: Convert span to size_t Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 10/19] selftests/resctrl: Express span internally in bytes Ilpo Järvinen
2023-07-17 13:14 ` [PATCH v5 11/19] selftests/resctrl: Remove duplicated preparation for span arg Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 12/19] selftests/resctrl: Remove "malloc_and_init_memory" param from run_fill_buf() Ilpo Järvinen
2023-07-25 14:49 ` Shuah Khan
2023-07-25 15:26 ` Reinette Chatre
2023-08-07 10:21 ` Ilpo Järvinen
2023-08-07 18:47 ` Shuah Khan [this message]
2023-08-07 19:02 ` Reinette Chatre
2023-07-17 13:15 ` [PATCH v5 13/19] selftests/resctrl: Remove unnecessary startptr global from fill_buf Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 14/19] selftests/resctrl: Improve parameter consistency in fill_buf Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 15/19] selftests/resctrl: Don't pass test name to fill_buf Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 16/19] selftests/resctrl: Don't use variable argument list for ->setup() Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 17/19] selftests/resctrl: Move CAT/CMT test global vars to function they are used in Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 18/19] selftests/resctrl: Pass the real number of tests to show_cache_info() Ilpo Järvinen
2023-07-17 13:15 ` [PATCH v5 19/19] selftests/resctrl: Remove test type checks from cat_val() Ilpo Järvinen
2023-07-17 15:11 ` [PATCH v5 00/19] selftests/resctrl: Fixes and cleanups Babu Moger
2023-07-18 6:47 ` Shaopeng Tan (Fujitsu)
2023-07-25 14:55 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd320704-a923-2e0e-a8ed-0693d294ee33@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox