Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Andrii Nakryiko <andrii@kernel.org>,
	 Eduard Zingerman <eddyz87@gmail.com>,
	Mykola Lysenko <mykolal@fb.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	 Daniel Borkmann <daniel@iogearbox.net>,
	 Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	 Yonghong Song <yonghong.song@linux.dev>,
	 John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	 Stanislav Fomichev <sdf@fomichev.me>,
	Hao Luo <haoluo@google.com>,  Jiri Olsa <jolsa@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	 bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH bpf-next] selftests, bpf: Skip MPLS test_tc_tunnel tests if MPLS is unavailable
Date: Fri, 27 Sep 2024 13:05:47 +0100	[thread overview]
Message-ID: <20240927-mpls-skip-v1-1-1bc38abf917e@kernel.org> (raw)

If MPLS is not available in the kernel then skip MPLS tests.

This avoids the test failing in situations where the test is not
supported by the underlying kernel.

In the case where all tests are run, just skip over the MPLS tests
without altering the exit code of the overall test run - there
is only one exit code in this scenario.

In the case where a single test is run, exit with KSFT_SKIP (4).

In both cases log an informative message.

Signed-off-by: Simon Horman <horms@kernel.org>
---
 tools/testing/selftests/bpf/test_tc_tunnel.sh | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/test_tc_tunnel.sh b/tools/testing/selftests/bpf/test_tc_tunnel.sh
index 7989ec608454..71cddabc4ade 100755
--- a/tools/testing/selftests/bpf/test_tc_tunnel.sh
+++ b/tools/testing/selftests/bpf/test_tc_tunnel.sh
@@ -102,6 +102,20 @@ wait_for_port() {
 	return 1
 }
 
+skip_mac() {
+	if [ "$1" = "mpls" ]; then
+		modprobe mpls_iptunnel || true
+		modprobe mpls_gso || true
+
+		if [ ! -e /proc/sys/net/mpls/platform_labels ]; then
+			echo -e "skip:    mpls tunnel not supported by kernel\n"
+			return # true
+		fi
+	fi
+
+	false
+}
+
 set -e
 
 # no arguments: automated test, run all
@@ -125,6 +139,8 @@ if [[ "$#" -eq "0" ]]; then
 	$0 ipv6 ip6vxlan eth 2000
 
 	for mac in none mpls eth ; do
+		! skip_mac "$mac" || continue
+
 		echo "ip gre $mac"
 		$0 ipv4 gre $mac 100
 
@@ -193,6 +209,10 @@ readonly tuntype=$2
 readonly mac=$3
 readonly datalen=$4
 
+if skip_mac "$mac"; then
+	exit 4 # KSFT_SKIP=4
+fi
+
 echo "encap ${addr1} to ${addr2}, type ${tuntype}, mac ${mac} len ${datalen}"
 
 trap cleanup EXIT
@@ -278,8 +298,6 @@ elif [[ "$tuntype" =~ (gre|vxlan) && "$mac" == "eth" ]]; then
 		  awk '/ether/ { print $2 }')
 	ip netns exec "${ns2}" ip link set testtun0 address $ethaddr
 elif [[ "$mac" == "mpls" ]]; then
-	modprobe mpls_iptunnel ||true
-	modprobe mpls_gso ||true
 	ip netns exec "${ns2}" sysctl -qw net.mpls.platform_labels=65536
 	ip netns exec "${ns2}" ip -f mpls route add 1000 dev lo
 	ip netns exec "${ns2}" ip link set lo up


             reply	other threads:[~2024-09-27 12:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 12:05 Simon Horman [this message]
2024-10-02 12:07 ` [PATCH bpf-next] selftests, bpf: Skip MPLS test_tc_tunnel tests if MPLS is unavailable Daniel Borkmann
2024-10-04 11:23   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240927-mpls-skip-v1-1-1bc38abf917e@kernel.org \
    --to=horms@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox