From: Simon Horman <horms@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
alexis.lothore@bootlin.com
Subject: Re: [PATCH bpf-next] selftests, bpf: Skip MPLS test_tc_tunnel tests if MPLS is unavailable
Date: Fri, 4 Oct 2024 12:23:09 +0100 [thread overview]
Message-ID: <20241004112309.GB1545787@kernel.org> (raw)
In-Reply-To: <6c80ed1a-6b6f-4920-9b80-a25d8b40cca4@iogearbox.net>
On Wed, Oct 02, 2024 at 02:07:54PM +0200, Daniel Borkmann wrote:
> [ +Alexis ]
>
> On 9/27/24 2:05 PM, Simon Horman wrote:
> > If MPLS is not available in the kernel then skip MPLS tests.
> >
> > This avoids the test failing in situations where the test is not
> > supported by the underlying kernel.
> >
> > In the case where all tests are run, just skip over the MPLS tests
> > without altering the exit code of the overall test run - there
> > is only one exit code in this scenario.
> >
> > In the case where a single test is run, exit with KSFT_SKIP (4).
> >
> > In both cases log an informative message.
> >
> > Signed-off-by: Simon Horman <horms@kernel.org>
>
> Are you running this as part of net selftests / CI which is why you
> need this? (And if yes, why excluding MPLS?)
Hi Daniel,
No, this was observed when running the test in a different harness.
I can find out why MPLS is excluded, but my assumption is because
it is not otherwise needed by the distro kernel that is being tested.
I entirely understand if that makes this patch out of scope for upstream.
Although having it upstream would be useful downstream.
> Alexis is working on converting tests like these into our BPF CI into
> test_progs, I'm not sure whether we need to make that more
> complex unless there is a compelling reason to exclude MPLS?
If the MPLS test(s) can somehow be excluded then that may meet the needs of
the test environment where this was observed, but I would need to check.
...
prev parent reply other threads:[~2024-10-04 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 12:05 [PATCH bpf-next] selftests, bpf: Skip MPLS test_tc_tunnel tests if MPLS is unavailable Simon Horman
2024-10-02 12:07 ` Daniel Borkmann
2024-10-04 11:23 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004112309.GB1545787@kernel.org \
--to=horms@kernel.org \
--cc=alexis.lothore@bootlin.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox