* [PATCH net] selftests: rds: move test.py to TEST_FILES
@ 2024-11-24 7:32 Hangbin Liu
2024-11-26 20:04 ` Allison Henderson
2024-11-28 9:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2024-11-24 7:32 UTC (permalink / raw)
To: netdev
Cc: Allison Henderson, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, Shuah Khan, Vegard Nossum, Chuck Lever,
linux-rdma, rds-devel, linux-kselftest, linux-kernel, Hangbin Liu,
Maximilian Heyne
The test.py should not be run separately. It should be run via run.sh,
which will do some sanity checks first. Move the test.py from TEST_PROGS
to TEST_FILES.
Reported-by: Maximilian Heyne <mheyne@amazon.de>
Closes: https://lore.kernel.org/netdev/20241122150129.GB18887@dev-dsk-mheyne-1b-55676e6a.eu-west-1.amazon.com
Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/net/rds/Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
index 1803c39dbacb..612a7219990e 100644
--- a/tools/testing/selftests/net/rds/Makefile
+++ b/tools/testing/selftests/net/rds/Makefile
@@ -3,10 +3,9 @@
all:
@echo mk_build_dir="$(shell pwd)" > include.sh
-TEST_PROGS := run.sh \
- test.py
+TEST_PROGS := run.sh
-TEST_FILES := include.sh
+TEST_FILES := include.sh test.py
EXTRA_CLEAN := /tmp/rds_logs include.sh
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] selftests: rds: move test.py to TEST_FILES
2024-11-24 7:32 [PATCH net] selftests: rds: move test.py to TEST_FILES Hangbin Liu
@ 2024-11-26 20:04 ` Allison Henderson
2024-11-28 9:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Allison Henderson @ 2024-11-26 20:04 UTC (permalink / raw)
To: netdev@vger.kernel.org, liuhangbin@gmail.com
Cc: linux-rdma@vger.kernel.org, davem@davemloft.net, Vegard Nossum,
Chuck Lever III, shuah@kernel.org, rds-devel@oss.oracle.com,
linux-kernel@vger.kernel.org, pabeni@redhat.com, horms@kernel.org,
edumazet@google.com, kuba@kernel.org,
linux-kselftest@vger.kernel.org, mheyne@amazon.de
On Sun, 2024-11-24 at 07:32 +0000, Hangbin Liu wrote:
> The test.py should not be run separately. It should be run via run.sh,
> which will do some sanity checks first. Move the test.py from TEST_PROGS
> to TEST_FILES.
This looks fine to me. Thanks for the catch!
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
>
> Reported-by: Maximilian Heyne <mheyne@amazon.de>
> Closes: https://lore.kernel.org/netdev/20241122150129.GB18887@dev-dsk-mheyne-1b-55676e6a.eu-west-1.amazon.com
> Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> tools/testing/selftests/net/rds/Makefile | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
> index 1803c39dbacb..612a7219990e 100644
> --- a/tools/testing/selftests/net/rds/Makefile
> +++ b/tools/testing/selftests/net/rds/Makefile
> @@ -3,10 +3,9 @@
> all:
> @echo mk_build_dir="$(shell pwd)" > include.sh
>
> -TEST_PROGS := run.sh \
> - test.py
> +TEST_PROGS := run.sh
>
> -TEST_FILES := include.sh
> +TEST_FILES := include.sh test.py
>
> EXTRA_CLEAN := /tmp/rds_logs include.sh
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] selftests: rds: move test.py to TEST_FILES
2024-11-24 7:32 [PATCH net] selftests: rds: move test.py to TEST_FILES Hangbin Liu
2024-11-26 20:04 ` Allison Henderson
@ 2024-11-28 9:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-11-28 9:30 UTC (permalink / raw)
To: Hangbin Liu
Cc: netdev, allison.henderson, davem, edumazet, kuba, pabeni, horms,
shuah, vegard.nossum, chuck.lever, linux-rdma, rds-devel,
linux-kselftest, linux-kernel, mheyne
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Sun, 24 Nov 2024 07:32:43 +0000 you wrote:
> The test.py should not be run separately. It should be run via run.sh,
> which will do some sanity checks first. Move the test.py from TEST_PROGS
> to TEST_FILES.
>
> Reported-by: Maximilian Heyne <mheyne@amazon.de>
> Closes: https://lore.kernel.org/netdev/20241122150129.GB18887@dev-dsk-mheyne-1b-55676e6a.eu-west-1.amazon.com
> Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>
> [...]
Here is the summary with links:
- [net] selftests: rds: move test.py to TEST_FILES
https://git.kernel.org/netdev/net/c/663a91747553
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-28 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-24 7:32 [PATCH net] selftests: rds: move test.py to TEST_FILES Hangbin Liu
2024-11-26 20:04 ` Allison Henderson
2024-11-28 9:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox