From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] selftests/nolibc: drop call to prepare target
Date: Sat, 1 Feb 2025 11:03:43 +0100 [thread overview]
Message-ID: <20250201100343.GA5849@1wt.eu> (raw)
In-Reply-To: <20250123-nolibc-config-v2-2-5701c35995d6@weissschuh.net>
On Thu, Jan 23, 2025 at 08:37:38AM +0100, Thomas Weißschuh wrote:
> The "prepare" target does not need to be run manually.
> kbuild knows when to use it on its own and the target is not even
> documented.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> tools/testing/selftests/nolibc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile
> index ba044c8a042ce345ff90bdd35569de4b5acd117d..464165e3d9175d283ec0ed14765df29427b6de38 100644
> --- a/tools/testing/selftests/nolibc/Makefile
> +++ b/tools/testing/selftests/nolibc/Makefile
> @@ -261,7 +261,7 @@ initramfs: nolibc-test
> $(Q)cp nolibc-test initramfs/init
>
> defconfig:
> - $(Q)$(MAKE) -C $(srctree) ARCH=$(ARCH) CC=$(CC) CROSS_COMPILE=$(CROSS_COMPILE) mrproper $(DEFCONFIG) prepare
> + $(Q)$(MAKE) -C $(srctree) ARCH=$(ARCH) CC=$(CC) CROSS_COMPILE=$(CROSS_COMPILE) mrproper $(DEFCONFIG)
I'm pretty sure that in the past I had to manually do it for certain
rebuilds (out of the nolibc-test context), but I cannot say for sure
when, but I did definitely discover it when trying to fix some build
issues. It's very possible that the issues that it used to fix have
long been fixed and that it remained in fingers memory, so I'm fine
with dropping it and we'll see. If we ever discover we need to bring
it back, at least we'll explain why in a commit message this time.
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
next prev parent reply other threads:[~2025-02-01 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 7:37 [PATCH v2 0/5] selftests/nolibc: test kernel configuration cleanups Thomas Weißschuh
2025-01-23 7:37 ` [PATCH v2 1/5] selftests/nolibc: drop custom EXTRACONFIG functionality Thomas Weißschuh
2025-02-01 10:13 ` Willy Tarreau
2025-02-01 10:17 ` Thomas Weißschuh
2025-02-01 10:20 ` Willy Tarreau
2025-01-23 7:37 ` [PATCH v2 2/5] selftests/nolibc: drop call to prepare target Thomas Weißschuh
2025-02-01 10:03 ` Willy Tarreau [this message]
2025-01-23 7:37 ` [PATCH v2 3/5] selftests/nolibc: drop call to mrproper target Thomas Weißschuh
2025-02-01 10:07 ` Willy Tarreau
2025-01-23 7:37 ` [PATCH v2 4/5] selftests/nolibc: execute defconfig before other targets Thomas Weißschuh
2025-02-01 10:09 ` Willy Tarreau
2025-01-23 7:37 ` [PATCH v2 5/5] selftests/nolibc: always keep test kernel configuration up to date Thomas Weißschuh
2025-02-01 10:13 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250201100343.GA5849@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox