From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] selftests/nolibc: drop call to mrproper target
Date: Sat, 1 Feb 2025 11:07:55 +0100 [thread overview]
Message-ID: <20250201100755.GB5849@1wt.eu> (raw)
In-Reply-To: <20250123-nolibc-config-v2-3-5701c35995d6@weissschuh.net>
On Thu, Jan 23, 2025 at 08:37:39AM +0100, Thomas Weißschuh wrote:
> "mrproper" unnecessarily cleans a lot of files.
> kbuild is smart enough to handle changed configurations,
> so the cleanup is not necessary and only leads to excessive rebuilds.
Generally for me the mrproper has been needed when switching between archs
or configs that leave generated files that pollute the build of others.
Also a typical case is during certain bisects. It has happened to me many
times to completely fail a bisect due to not cleaning everything. With
that said I agree that cleaning by default is painful and I also hate doing
that.
So maybe better get rid of it indeed, and leave it to the user to decide to
clean or not.
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
next prev parent reply other threads:[~2025-02-01 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 7:37 [PATCH v2 0/5] selftests/nolibc: test kernel configuration cleanups Thomas Weißschuh
2025-01-23 7:37 ` [PATCH v2 1/5] selftests/nolibc: drop custom EXTRACONFIG functionality Thomas Weißschuh
2025-02-01 10:13 ` Willy Tarreau
2025-02-01 10:17 ` Thomas Weißschuh
2025-02-01 10:20 ` Willy Tarreau
2025-01-23 7:37 ` [PATCH v2 2/5] selftests/nolibc: drop call to prepare target Thomas Weißschuh
2025-02-01 10:03 ` Willy Tarreau
2025-01-23 7:37 ` [PATCH v2 3/5] selftests/nolibc: drop call to mrproper target Thomas Weißschuh
2025-02-01 10:07 ` Willy Tarreau [this message]
2025-01-23 7:37 ` [PATCH v2 4/5] selftests/nolibc: execute defconfig before other targets Thomas Weißschuh
2025-02-01 10:09 ` Willy Tarreau
2025-01-23 7:37 ` [PATCH v2 5/5] selftests/nolibc: always keep test kernel configuration up to date Thomas Weißschuh
2025-02-01 10:13 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250201100755.GB5849@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox