* [PATCH] kunit: configs: Enable coverage of the bitfield packing library
@ 2025-04-25 22:19 Mark Brown
2025-05-09 19:47 ` Rae Moar
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2025-04-25 22:19 UTC (permalink / raw)
To: Brendan Higgins, David Gow, Rae Moar
Cc: linux-kselftest, kunit-dev, linux-kernel, Mark Brown
There are KUnit tests for the bitfield packing library but these depend
on CONFIG_PACKING which is not enabled by anything in either the
existing KUnit all_tests.config or the base UML config it runs on as
standard. Enable that in all_tests.config to improve coverage.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
tools/testing/kunit/configs/all_tests.config | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
index cdd9782f9646..b0223b7aebde 100644
--- a/tools/testing/kunit/configs/all_tests.config
+++ b/tools/testing/kunit/configs/all_tests.config
@@ -51,3 +51,5 @@ CONFIG_SOUND=y
CONFIG_SND=y
CONFIG_SND_SOC=y
CONFIG_SND_SOC_TOPOLOGY_BUILD=y
+
+CONFIG_PACKING=y
---
base-commit: 8ffd015db85fea3e15a77027fda6c02ced4d2444
change-id: 20250422-kunit-enable-missing-tests-9189ee930cae
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kunit: configs: Enable coverage of the bitfield packing library
2025-04-25 22:19 [PATCH] kunit: configs: Enable coverage of the bitfield packing library Mark Brown
@ 2025-05-09 19:47 ` Rae Moar
0 siblings, 0 replies; 2+ messages in thread
From: Rae Moar @ 2025-05-09 19:47 UTC (permalink / raw)
To: Mark Brown
Cc: Brendan Higgins, David Gow, linux-kselftest, kunit-dev,
linux-kernel
On Fri, Apr 25, 2025 at 6:19 PM Mark Brown <broonie@kernel.org> wrote:
>
> There are KUnit tests for the bitfield packing library but these depend
> on CONFIG_PACKING which is not enabled by anything in either the
> existing KUnit all_tests.config or the base UML config it runs on as
> standard. Enable that in all_tests.config to improve coverage.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Hello,
This looks good to me. It adds about 70 tests to the "alltests" run.
They all seem to pass and run fast so I am happy to add this.
Reviewed-by: Rae Moar <rmoar@google.com>
Thanks!
-Rae
> ---
> tools/testing/kunit/configs/all_tests.config | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
> index cdd9782f9646..b0223b7aebde 100644
> --- a/tools/testing/kunit/configs/all_tests.config
> +++ b/tools/testing/kunit/configs/all_tests.config
> @@ -51,3 +51,5 @@ CONFIG_SOUND=y
> CONFIG_SND=y
> CONFIG_SND_SOC=y
> CONFIG_SND_SOC_TOPOLOGY_BUILD=y
> +
> +CONFIG_PACKING=y
>
> ---
> base-commit: 8ffd015db85fea3e15a77027fda6c02ced4d2444
> change-id: 20250422-kunit-enable-missing-tests-9189ee930cae
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-09 19:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-25 22:19 [PATCH] kunit: configs: Enable coverage of the bitfield packing library Mark Brown
2025-05-09 19:47 ` Rae Moar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox