[PATCH] selftests/futex: Conditionally run futex_numa_mpol test

[PATCH] selftests/futex: Conditionally run futex_numa_mpol test

[Wake Liu]

The futex_numa_mpol test requires libnuma, which is not available on
all platforms. When the test is not built, the run.sh script fails
because it unconditionally tries to execute the test binary.

Check for the futex_numa_mpol executable before running it. If the
binary is not present, print a skip message and continue.

This allows the test suite to run successfully on platforms that do
not have libnuma and therefore do not build the futex_numa_mpol
test.

Signed-off-by: Wake Liu <wakel@google.com>
---
 tools/testing/selftests/futex/functional/run.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/futex/functional/run.sh b/tools/testing/selftests/futex/functional/run.sh
index 81739849f299..f3e43eb806bf 100755
--- a/tools/testing/selftests/futex/functional/run.sh
+++ b/tools/testing/selftests/futex/functional/run.sh
@@ -88,4 +88,8 @@ echo
 ./futex_priv_hash -g $COLOR
 
 echo
-./futex_numa_mpol $COLOR
+if [ -x ./futex_numa_mpol ]; then
+    ./futex_numa_mpol $COLOR
+else
+    echo "SKIP: futex_numa_mpol (not built)"
+fi
-- 
2.51.0.355.g5224444f11-goog

Re: [PATCH] selftests/futex: Conditionally run futex_numa_mpol test

[André Almeida]

Em 08/09/2025 08:37, Wake Liu escreveu:
> The futex_numa_mpol test requires libnuma, which is not available on
> all platforms. When the test is not built, the run.sh script fails
> because it unconditionally tries to execute the test binary.
> 
> Check for the futex_numa_mpol executable before running it. If the
> binary is not present, print a skip message and continue.
> 
> This allows the test suite to run successfully on platforms that do
> not have libnuma and therefore do not build the futex_numa_mpol
> test.
> 
> Signed-off-by: Wake Liu <wakel@google.com>

Reviewed-by: André Almeida <andrealmeid@igalia.com>

Re: [PATCH] selftests/futex: Conditionally run futex_numa_mpol test

[Sebastian Andrzej Siewior]

On 2025-09-08 19:37:20 [+0800], Wake Liu wrote:
> The futex_numa_mpol test requires libnuma, which is not available on
> all platforms. When the test is not built, the run.sh script fails
> because it unconditionally tries to execute the test binary.
> 
> Check for the futex_numa_mpol executable before running it. If the
> binary is not present, print a skip message and continue.
> 
> This allows the test suite to run successfully on platforms that do
> not have libnuma and therefore do not build the futex_numa_mpol
> test.

If you skip the test, how to you compile this?
Does
	https://lore.kernel.org/all/20250818135458.F352St6W@linutronix.de/

help?

> Signed-off-by: Wake Liu <wakel@google.com>
> ---
>  tools/testing/selftests/futex/functional/run.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/futex/functional/run.sh b/tools/testing/selftests/futex/functional/run.sh
> index 81739849f299..f3e43eb806bf 100755
> --- a/tools/testing/selftests/futex/functional/run.sh
> +++ b/tools/testing/selftests/futex/functional/run.sh
> @@ -88,4 +88,8 @@ echo
>  ./futex_priv_hash -g $COLOR
>  
>  echo
> -./futex_numa_mpol $COLOR
> +if [ -x ./futex_numa_mpol ]; then
> +    ./futex_numa_mpol $COLOR
> +else
> +    echo "SKIP: futex_numa_mpol (not built)"
> +fi

Sebastian