* [PATCH] selftests/kvm: remove stale TODO in xapic_state_test
@ 2025-09-08 21:05 Sukrut Heroorkar
2025-09-24 18:07 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: Sukrut Heroorkar @ 2025-09-08 21:05 UTC (permalink / raw)
To: Sean Christopherson, Paolo Bonzini, Shuah Khan,
open list:KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86),
open list:KERNEL SELFTEST FRAMEWORK, open list
Cc: skhan, david.hunter.linux, Sukrut Heroorkar
The TODO about using the number of vCPUs instead of vcpu.id + 1
was already addressed by commit 376bc1b458c9 ("KVM: selftests: Don't
assume vcpu->id is '0' in xAPIC state test"). The comment is now
stale and can be removed.
Signed-off-by: Sukrut Heroorkar <hsukrut3@gmail.com>
---
tools/testing/selftests/kvm/x86/xapic_state_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/kvm/x86/xapic_state_test.c b/tools/testing/selftests/kvm/x86/xapic_state_test.c
index fdebff1165c7..3b4814c55722 100644
--- a/tools/testing/selftests/kvm/x86/xapic_state_test.c
+++ b/tools/testing/selftests/kvm/x86/xapic_state_test.c
@@ -120,8 +120,8 @@ static void test_icr(struct xapic_vcpu *x)
__test_icr(x, icr | i);
/*
- * Send all flavors of IPIs to non-existent vCPUs. TODO: use number of
- * vCPUs, not vcpu.id + 1. Arbitrarily use vector 0xff.
+ * Send all flavors of IPIs to non-existent vCPUs. Arbitrarily use
+ * vector 0xff.
*/
icr = APIC_INT_ASSERT | 0xff;
for (i = 0; i < 0xff; i++) {
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/kvm: remove stale TODO in xapic_state_test
2025-09-08 21:05 [PATCH] selftests/kvm: remove stale TODO in xapic_state_test Sukrut Heroorkar
@ 2025-09-24 18:07 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2025-09-24 18:07 UTC (permalink / raw)
To: Sean Christopherson, Paolo Bonzini, Shuah Khan, kvm,
linux-kselftest, linux-kernel, Sukrut Heroorkar
Cc: skhan, david.hunter.linux
On Mon, 08 Sep 2025 23:05:46 +0200, Sukrut Heroorkar wrote:
> The TODO about using the number of vCPUs instead of vcpu.id + 1
> was already addressed by commit 376bc1b458c9 ("KVM: selftests: Don't
> assume vcpu->id is '0' in xAPIC state test"). The comment is now
> stale and can be removed.
Applied to kvm-x86 selftests, thanks!
[1/1] selftests/kvm: remove stale TODO in xapic_state_test
https://github.com/kvm-x86/linux/commit/ff86b48d4ce3
--
https://github.com/kvm-x86/linux/tree/next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-24 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-08 21:05 [PATCH] selftests/kvm: remove stale TODO in xapic_state_test Sukrut Heroorkar
2025-09-24 18:07 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox