[PATCH net-next] selftests: af_unix: don't use SKIP for expected failures

[PATCH net-next] selftests: af_unix: don't use SKIP for expected failures

[Jakub Kicinski]

netdev CI reserves SKIP in selftests for cases which can't be executed
due to setup issues, like missing or old commands. Tests which are
expected to fail must use XFAIL.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: kuniyu@google.com
CC: adelodunolaoluwa@yahoo.com
CC: shuah@kernel.org
CC: linux-kselftest@vger.kernel.org
---
 tools/testing/selftests/net/af_unix/unix_connreset.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/af_unix/unix_connreset.c b/tools/testing/selftests/net/af_unix/unix_connreset.c
index bffef2b54bfd..6eb936207b31 100644
--- a/tools/testing/selftests/net/af_unix/unix_connreset.c
+++ b/tools/testing/selftests/net/af_unix/unix_connreset.c
@@ -161,8 +161,12 @@ TEST_F(unix_sock, reset_closed_embryo)
 	char buf[16] = {};
 	ssize_t n;
 
-	if (variant->socket_type == SOCK_DGRAM)
-		SKIP(return, "This test only applies to SOCK_STREAM and SOCK_SEQPACKET");
+	if (variant->socket_type == SOCK_DGRAM) {
+		snprintf(_metadata->results->reason,
+			 sizeof(_metadata->results->reason),
+			 "Test only applies to SOCK_STREAM and SOCK_SEQPACKET");
+		exit(KSFT_XFAIL);
+	}
 
 	/* Close server without accept()ing */
 	close(self->server);
-- 
2.51.1

Re: [PATCH net-next] selftests: af_unix: don't use SKIP for expected failures

[Kuniyuki Iwashima]

On Sat, Nov 22, 2025 at 6:16 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> netdev CI reserves SKIP in selftests for cases which can't be executed
> due to setup issues, like missing or old commands. Tests which are
> expected to fail must use XFAIL.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Good to know that, thanks !

Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>


> ---
> CC: kuniyu@google.com
> CC: adelodunolaoluwa@yahoo.com
> CC: shuah@kernel.org
> CC: linux-kselftest@vger.kernel.org
> ---
>  tools/testing/selftests/net/af_unix/unix_connreset.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/af_unix/unix_connreset.c b/tools/testing/selftests/net/af_unix/unix_connreset.c
> index bffef2b54bfd..6eb936207b31 100644
> --- a/tools/testing/selftests/net/af_unix/unix_connreset.c
> +++ b/tools/testing/selftests/net/af_unix/unix_connreset.c
> @@ -161,8 +161,12 @@ TEST_F(unix_sock, reset_closed_embryo)
>         char buf[16] = {};
>         ssize_t n;
>
> -       if (variant->socket_type == SOCK_DGRAM)
> -               SKIP(return, "This test only applies to SOCK_STREAM and SOCK_SEQPACKET");
> +       if (variant->socket_type == SOCK_DGRAM) {
> +               snprintf(_metadata->results->reason,
> +                        sizeof(_metadata->results->reason),
> +                        "Test only applies to SOCK_STREAM and SOCK_SEQPACKET");
> +               exit(KSFT_XFAIL);
> +       }
>
>         /* Close server without accept()ing */
>         close(self->server);
> --
> 2.51.1
>

Re: [PATCH net-next] selftests: af_unix: don't use SKIP for expected failures

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 22 Nov 2025 18:16:01 -0800 you wrote:
> netdev CI reserves SKIP in selftests for cases which can't be executed
> due to setup issues, like missing or old commands. Tests which are
> expected to fail must use XFAIL.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kuniyu@google.com
> CC: adelodunolaoluwa@yahoo.com
> CC: shuah@kernel.org
> CC: linux-kselftest@vger.kernel.org
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: af_unix: don't use SKIP for expected failures
    https://git.kernel.org/netdev/net-next/c/e254c212cd9c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html