From: Cosmin Ratiu <cratiu@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>, Cosmin Ratiu <cratiu@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>,
<linux-kselftest@vger.kernel.org>
Subject: [PATCH net-next 2/2] selftests: drv-net: psp: Don't fail psp_responder when no PSP devs found
Date: Mon, 5 Jan 2026 12:04:24 +0200 [thread overview]
Message-ID: <20260105100424.2626542-3-cratiu@nvidia.com> (raw)
In-Reply-To: <20260105100424.2626542-1-cratiu@nvidia.com>
psp_responder, used in the PSP self tests, fails when no PSP devices are
found. This makes the PSP test time out on connecting to the responder
and throw out an unpleasant Python exception.
Change psp_responder to open the server socket and listen for control
connections normally, and leave the skipping of the various test cases
which require a PSP device (~most, but not all of them) to the parent
test. This results in output like:
ok 1 psp.test_case # SKIP No PSP devices found
[...]
ok 12 psp.dev_get_device # SKIP No PSP devices found
ok 13 psp.dev_get_device_bad
ok 14 psp.dev_rotate # SKIP No PSP devices found
[...]
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
---
tools/testing/selftests/drivers/net/psp_responder.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/drivers/net/psp_responder.c b/tools/testing/selftests/drivers/net/psp_responder.c
index 8d2bad134e63..b240888068d3 100644
--- a/tools/testing/selftests/drivers/net/psp_responder.c
+++ b/tools/testing/selftests/drivers/net/psp_responder.c
@@ -430,12 +430,8 @@ int main(int argc, char **argv)
}
dev_list = psp_dev_get_dump(ys);
- if (ynl_dump_empty(dev_list)) {
- if (ys->err.code)
- goto err_close;
- fprintf(stderr, "No PSP devices\n");
- goto err_close_silent;
- }
+ if (ynl_dump_empty(dev_list) && ys->err.code)
+ goto err_close;
ynl_dump_foreach(dev_list, d) {
if (opts.devid) {
@@ -464,7 +460,7 @@ int main(int argc, char **argv)
opts.devid = first_id;
}
- if (ver_ena != ver_cap) {
+ if (opts.devid && ver_ena != ver_cap) {
ret = psp_dev_set_ena(ys, opts.devid, ver_cap);
if (ret)
goto err_close;
@@ -472,7 +468,8 @@ int main(int argc, char **argv)
ret = run_responder(ys, &opts);
- if (ver_ena != ver_cap && psp_dev_set_ena(ys, opts.devid, ver_ena))
+ if (opts.devid && ver_ena != ver_cap &&
+ psp_dev_set_ena(ys, opts.devid, ver_ena))
fprintf(stderr, "WARN: failed to set the PSP versions back\n");
ynl_sock_destroy(ys);
--
2.45.0
next prev parent reply other threads:[~2026-01-05 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 10:04 [PATCH net-next 0/2] PSP self test improvements Cosmin Ratiu
2026-01-05 10:04 ` [PATCH net-next 1/2] selftests: drv-net: psp: Use first device when multiple are present Cosmin Ratiu
2026-01-06 1:44 ` Jakub Kicinski
2026-01-07 11:44 ` Cosmin Ratiu
2026-01-05 10:04 ` Cosmin Ratiu [this message]
2026-01-06 1:52 ` [PATCH net-next 2/2] selftests: drv-net: psp: Don't fail psp_responder when no PSP devs found Jakub Kicinski
2026-01-07 11:47 ` Cosmin Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105100424.2626542-3-cratiu@nvidia.com \
--to=cratiu@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox