Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: <netdev@vger.kernel.org>, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
	Carolina Jubran <cjubran@nvidia.com>,
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] selftests: drv-net: psp: Don't fail psp_responder when no PSP devs found
Date: Mon, 5 Jan 2026 17:52:06 -0800	[thread overview]
Message-ID: <20260105175206.7b74067d@kernel.org> (raw)
In-Reply-To: <20260105100424.2626542-3-cratiu@nvidia.com>

On Mon, 5 Jan 2026 12:04:24 +0200 Cosmin Ratiu wrote:
> psp_responder, used in the PSP self tests, fails when no PSP devices are
> found. This makes the PSP test time out on connecting to the responder
> and throw out an unpleasant Python exception.

Indeed, handling the errors for responders within bkg() is quite
annoying. Or at least I didn't find a clean way to do it.

> Change psp_responder to open the server socket and listen for control
> connections normally, and leave the skipping of the various test cases
> which require a PSP device (~most, but not all of them) to the parent
> test. This results in output like:
> 
> ok 1 psp.test_case # SKIP No PSP devices found
> [...]
> ok 12 psp.dev_get_device # SKIP No PSP devices found
> ok 13 psp.dev_get_device_bad
> ok 14 psp.dev_rotate # SKIP No PSP devices found
> [...]

To be clear - in this case the DUT also doesn't have a PSP device?
I'm struggling to connect the dots on how this error msg could come
from psp_responder.

  reply	other threads:[~2026-01-06  1:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05 10:04 [PATCH net-next 0/2] PSP self test improvements Cosmin Ratiu
2026-01-05 10:04 ` [PATCH net-next 1/2] selftests: drv-net: psp: Use first device when multiple are present Cosmin Ratiu
2026-01-06  1:44   ` Jakub Kicinski
2026-01-07 11:44     ` Cosmin Ratiu
2026-01-05 10:04 ` [PATCH net-next 2/2] selftests: drv-net: psp: Don't fail psp_responder when no PSP devs found Cosmin Ratiu
2026-01-06  1:52   ` Jakub Kicinski [this message]
2026-01-07 11:47     ` Cosmin Ratiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260105175206.7b74067d@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=cjubran@nvidia.com \
    --cc=cratiu@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox