From: Greg KH <gregkh@linuxfoundation.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: stable@vger.kernel.org, kevin.brodsky@arm.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 6.12.y 00/14] Address pkey self test failures.
Date: Thu, 19 Feb 2026 12:27:10 +0100 [thread overview]
Message-ID: <2026021904-unclothed-flavored-cdf7@gregkh> (raw)
In-Reply-To: <20260219101318.2442406-1-harshit.m.mogalapalli@oracle.com>
On Thu, Feb 19, 2026 at 02:13:04AM -0800, Harshit Mogalapalli wrote:
> Hi stable maintainers,
>
> When pkey_sighandler_tests_64 is run on machines with CPUs that don't
> support pkeys, instead of skipping the tests return SIGILL(illegal
> instruction).
>
> # gdb ./pkey_sighandler_tests_64
>
> (gdb) info registers rip
> rip 0x402779 0x402779 <thread_segv_with_pkey0_disabled+9>
> (gdb) disassemble /r $rip-8,$rip+8
> Dump of assembler code from 0x402771 to 0x402781:
> 0x0000000000402771 <thread_segv_with_pkey0_disabled+1>: c9 leave
> 0x0000000000402772 <thread_segv_with_pkey0_disabled+2>: b8 55 55 55 55 mov $0x55555555,%eax
> 0x0000000000402777 <thread_segv_with_pkey0_disabled+7>: 89 ca mov %ecx,%edx
> => 0x0000000000402779 <thread_segv_with_pkey0_disabled+9>: 0f 01 ef wrpkru
> 0x000000000040277c <thread_segv_with_pkey0_disabled+12>: 0f 01 ee rdpkru
> 0x000000000040277f <thread_segv_with_pkey0_disabled+15>: 3d 55 55 55 55 cmp
>
> Tests result in:
>
> ./pkey_sighandler_tests_64
> TAP version 13
> 1..5
> Illegal instruction (core dumped)
>
> This is because 6.12.y commit: 1c6b1d4889d7 ("selftests/mm: skip
> pkey_sighandler_tests if support is missing") like upstream and
> backporting that needed few prerequsites, during this process I have
> seen a few build warnings, so also included patches that help fix these
> build warnings in the selftests.
>
> All are clean cherry-picks. After patching the selftests the test is
> correctly skipped. These additional backports cleansup the code and
> avoids the need for conflict resolution and might help future backports.
Shouldn't you be always running the latest selftests on older kernels?
We don't always keep selftests up to date at all, as you can see here,
but newer selftests should ALWAYS work with older kernels.
I think trying to keep these all up to date is going to be "a lot", are
you sure it is going to be worth it?
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-19 11:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 10:13 [PATCH 6.12.y 00/14] Address pkey self test failures Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 01/14] selftests/mm: fix condition in uffd_move_test_common() Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 02/14] selftests/mm: fix -Wmaybe-uninitialized warnings Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 03/14] selftests/mm: fix strncpy() length Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 04/14] selftests/mm: Define PKEY_UNRESTRICTED for pkey_sighandler_tests Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 05/14] selftests/mm: Use generic pkey register manipulation Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 06/14] selftests/mm: fix -Warray-bounds warnings in pkey_sighandler_tests Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 07/14] selftests/mm: remove unused pkey helpers Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 08/14] selftests/mm: define types using typedef in pkey-helpers.h Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 09/14] selftests/mm: ensure pkey-*.h define inline functions only Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 10/14] selftests/mm: remove empty pkey helper definition Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 11/14] selftests/mm: ensure non-global pkey symbols are marked static Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 12/14] selftests/mm: use sys_pkey helpers consistently Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 13/14] selftests/mm: rename pkey register macro Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 14/14] selftests/mm: skip pkey_sighandler_tests if support is missing Harshit Mogalapalli
2026-02-19 11:27 ` Greg KH [this message]
2026-02-20 23:08 ` [PATCH 6.12.y 00/14] Address pkey self test failures Harshit Mogalapalli
2026-02-21 0:19 ` Shuah Khan
2026-02-23 6:30 ` Harshit Mogalapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026021904-unclothed-flavored-cdf7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox