From: Shuah Khan <skhan@linuxfoundation.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
Greg KH <gregkh@linuxfoundation.org>,
"shuah@kernel.org" <shuah@kernel.org>
Cc: stable@vger.kernel.org, kevin.brodsky@arm.com,
Ramanan Govindarajan <ramanan.govindarajan@oracle.com>,
linux-kselftest@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 6.12.y 00/14] Address pkey self test failures.
Date: Fri, 20 Feb 2026 17:19:03 -0700 [thread overview]
Message-ID: <a45eaddb-9e17-4e82-8a78-a1d1f6e3d735@linuxfoundation.org> (raw)
In-Reply-To: <e1cb6b3f-ab40-46a8-a338-70e4a18f687b@oracle.com>
On 2/20/26 16:08, Harshit Mogalapalli wrote:
> Hi Greg and Shuah,
>
> On 19/02/26 16:57, Greg KH wrote:
>>> All are clean cherry-picks. After patching the selftests the test is
>>> correctly skipped. These additional backports cleansup the code and
>>> avoids the need for conflict resolution and might help future backports.
>> Shouldn't you be always running the latest selftests on older kernels?
>> We don't always keep selftests up to date at all, as you can see here,
>> but newer selftests should ALWAYS work with older kernels.
>>
>
> Thanks for sharing your insights on this.
>
> Couple of problems around this, would really appreciate your guidance on this.
>
> 1. Not all new selftests written might be correctly skipping if the feature is not supported in older kernels.
They should be skipping if a feature/configuration isn't supported.
The right approach is to fix the test to skip.
thanks,
-- Shuah
next prev parent reply other threads:[~2026-02-21 0:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 10:13 [PATCH 6.12.y 00/14] Address pkey self test failures Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 01/14] selftests/mm: fix condition in uffd_move_test_common() Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 02/14] selftests/mm: fix -Wmaybe-uninitialized warnings Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 03/14] selftests/mm: fix strncpy() length Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 04/14] selftests/mm: Define PKEY_UNRESTRICTED for pkey_sighandler_tests Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 05/14] selftests/mm: Use generic pkey register manipulation Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 06/14] selftests/mm: fix -Warray-bounds warnings in pkey_sighandler_tests Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 07/14] selftests/mm: remove unused pkey helpers Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 08/14] selftests/mm: define types using typedef in pkey-helpers.h Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 09/14] selftests/mm: ensure pkey-*.h define inline functions only Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 10/14] selftests/mm: remove empty pkey helper definition Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 11/14] selftests/mm: ensure non-global pkey symbols are marked static Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 12/14] selftests/mm: use sys_pkey helpers consistently Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 13/14] selftests/mm: rename pkey register macro Harshit Mogalapalli
2026-02-19 10:13 ` [PATCH 6.12.y 14/14] selftests/mm: skip pkey_sighandler_tests if support is missing Harshit Mogalapalli
2026-02-19 11:27 ` [PATCH 6.12.y 00/14] Address pkey self test failures Greg KH
2026-02-20 23:08 ` Harshit Mogalapalli
2026-02-21 0:19 ` Shuah Khan [this message]
2026-02-23 6:30 ` Harshit Mogalapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a45eaddb-9e17-4e82-8a78-a1d1f6e3d735@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=ramanan.govindarajan@oracle.com \
--cc=sashal@kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox