* [RFC PATCH v2 08/10] selftests/damon/_damon_sysfs: support goal_tuner setup
2026-03-04 4:41 [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms SeongJae Park
@ 2026-03-04 4:41 ` SeongJae Park
2026-03-04 4:41 ` [RFC PATCH v2 09/10] selftests/damon/drgn_dump_damon_status: support quota goal_tuner dumping SeongJae Park
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2026-03-04 4:41 UTC (permalink / raw)
Cc: SeongJae Park, Shuah Khan, damon, linux-kernel, linux-kselftest,
linux-mm
Add support of goal_tuner setup to the test-purpose DAMON sysfs
interface control helper, _damon_sysfs.py.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
tools/testing/selftests/damon/_damon_sysfs.py | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py
index 748778b563cd2..2b4df655d9fd0 100644
--- a/tools/testing/selftests/damon/_damon_sysfs.py
+++ b/tools/testing/selftests/damon/_damon_sysfs.py
@@ -130,15 +130,16 @@ class DamosQuota:
sz = None # size quota, in bytes
ms = None # time quota
goals = None # quota goals
+ goal_tuner = None # quota goal tuner
reset_interval_ms = None # quota reset interval
weight_sz_permil = None
weight_nr_accesses_permil = None
weight_age_permil = None
scheme = None # owner scheme
- def __init__(self, sz=0, ms=0, goals=None, reset_interval_ms=0,
- weight_sz_permil=0, weight_nr_accesses_permil=0,
- weight_age_permil=0):
+ def __init__(self, sz=0, ms=0, goals=None, goal_tuner='consist',
+ reset_interval_ms=0, weight_sz_permil=0,
+ weight_nr_accesses_permil=0, weight_age_permil=0):
self.sz = sz
self.ms = ms
self.reset_interval_ms = reset_interval_ms
@@ -146,6 +147,7 @@ class DamosQuota:
self.weight_nr_accesses_permil = weight_nr_accesses_permil
self.weight_age_permil = weight_age_permil
self.goals = goals if goals is not None else []
+ self.goal_tuner = goal_tuner
for idx, goal in enumerate(self.goals):
goal.idx = idx
goal.quota = self
@@ -191,6 +193,10 @@ class DamosQuota:
err = goal.stage()
if err is not None:
return err
+ err = write_file(
+ os.path.join(self.sysfs_dir(), 'goal_tuner'), self.goal_tuner)
+ if err is not None:
+ return err
return None
class DamosWatermarks:
--
2.47.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* [RFC PATCH v2 09/10] selftests/damon/drgn_dump_damon_status: support quota goal_tuner dumping
2026-03-04 4:41 [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms SeongJae Park
2026-03-04 4:41 ` [RFC PATCH v2 08/10] selftests/damon/_damon_sysfs: support goal_tuner setup SeongJae Park
@ 2026-03-04 4:41 ` SeongJae Park
2026-03-04 4:41 ` [RFC PATCH v2 10/10] selftests/damon/sysfs.py: test goal_tuner commit SeongJae Park
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2026-03-04 4:41 UTC (permalink / raw)
Cc: SeongJae Park, Shuah Khan, damon, linux-kernel, linux-kselftest,
linux-mm
Update drgn_dump_damon_status.py, which is being used to dump the
in-kernel DAMON status for tests, to dump goal_tuner setup status.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
tools/testing/selftests/damon/drgn_dump_damon_status.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/damon/drgn_dump_damon_status.py b/tools/testing/selftests/damon/drgn_dump_damon_status.py
index 5374d18d1fa8d..af99b07a4f565 100755
--- a/tools/testing/selftests/damon/drgn_dump_damon_status.py
+++ b/tools/testing/selftests/damon/drgn_dump_damon_status.py
@@ -110,6 +110,7 @@ def damos_quota_to_dict(quota):
['reset_interval', int],
['ms', int], ['sz', int],
['goals', damos_quota_goals_to_list],
+ ['goal_tuner', int],
['esz', int],
['weight_sz', int],
['weight_nr_accesses', int],
--
2.47.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* [RFC PATCH v2 10/10] selftests/damon/sysfs.py: test goal_tuner commit
2026-03-04 4:41 [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms SeongJae Park
2026-03-04 4:41 ` [RFC PATCH v2 08/10] selftests/damon/_damon_sysfs: support goal_tuner setup SeongJae Park
2026-03-04 4:41 ` [RFC PATCH v2 09/10] selftests/damon/drgn_dump_damon_status: support quota goal_tuner dumping SeongJae Park
@ 2026-03-04 4:41 ` SeongJae Park
2026-03-04 10:15 ` [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms Gutierrez Asier
2026-03-07 0:33 ` SeongJae Park
4 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2026-03-04 4:41 UTC (permalink / raw)
Cc: SeongJae Park, Shuah Khan, damon, linux-kernel, linux-kselftest,
linux-mm
Extend the near-full DAMON parameters commit selftest to commit
goal_tuner and confirm the internal status is updated as expected.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
tools/testing/selftests/damon/sysfs.py | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py
index 9cca71eb0325e..3aa5c91548a53 100755
--- a/tools/testing/selftests/damon/sysfs.py
+++ b/tools/testing/selftests/damon/sysfs.py
@@ -67,6 +67,12 @@ def assert_quota_committed(quota, dump):
assert_true(dump['sz'] == quota.sz, 'sz', dump)
for idx, qgoal in enumerate(quota.goals):
assert_quota_goal_committed(qgoal, dump['goals'][idx])
+ tuner_val = {
+ 'consist': 0,
+ 'temporal': 1,
+ }
+ assert_true(dump['goal_tuner'] == tuner_val[quota.goal_tuner],
+ 'goal_tuner', dump)
assert_true(dump['weight_sz'] == quota.weight_sz_permil, 'weight_sz', dump)
assert_true(dump['weight_nr_accesses'] == quota.weight_nr_accesses_permil,
'weight_nr_accesses', dump)
@@ -231,6 +237,7 @@ def main():
metric='node_mem_used_bp',
target_value=9950,
nid=1)],
+ goal_tuner='temporal',
reset_interval_ms=1500,
weight_sz_permil=20,
weight_nr_accesses_permil=200,
--
2.47.3
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms
2026-03-04 4:41 [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms SeongJae Park
` (2 preceding siblings ...)
2026-03-04 4:41 ` [RFC PATCH v2 10/10] selftests/damon/sysfs.py: test goal_tuner commit SeongJae Park
@ 2026-03-04 10:15 ` Gutierrez Asier
2026-03-04 15:03 ` SeongJae Park
2026-03-07 0:33 ` SeongJae Park
4 siblings, 1 reply; 7+ messages in thread
From: Gutierrez Asier @ 2026-03-04 10:15 UTC (permalink / raw)
To: SeongJae Park
Cc: Liam R. Howlett, Andrew Morton, David Hildenbrand,
Jonathan Corbet, Lorenzo Stoakes, Michal Hocko, Mike Rapoport,
Shuah Khan, Shuah Khan, Suren Baghdasaryan, Vlastimil Babka,
damon, linux-doc, linux-kernel, linux-kselftest, linux-mm
Hi SeongJae!
Nice idea for dynamic environments.
On 3/4/2026 7:41 AM, SeongJae Park wrote:
> Aim-oriented DAMOS quota auto-tuning uses a single tuning algorithm.
> The algorithm is designed to find a quota value that should be
> consistently kept for achieving the aimed goal for long term. It is
> useful and reliable at automatically operating systems that have dynamic
> environments in the long term.
>
> As always, however, no single algorithm fits all. When the environment
> has static characteristics or there are control towers in not only the
> kernel space but also the user space, the algorithm shows some
> limitations. In such environments, users want kernel work in a more
> short term deterministic way. Actually there were at least two reports
> [1,2] of such cases.
>
> Extend DAMOS quotas goal to support multiple quota tuning algorithms
> that users can select. Keep the current algorithm as the default one,
> to not break the old users. Also give it a name, "consist", as it is
> designed to "consistently" apply the DAMOS action. And introduce a new
> tuning algorithm, namely "temporal". It is designed to apply the DAMOS
> action only temporally, in a deterministic way. In more detail, as long
> as the goal is under-achieved, it uses the maximum quota available.
> Once the goal is over-achieved, it sets the quota zero.
I'm not sure "temporal" is the best name for this type of behaviour.
How about "by_score?". For example, "damos_goal_tune_esz_bp_by_score" and
DAMOS_QUOTA_GOAL_TUNER_BY_SCORE.
> Tests
> =====
>
> I confirmed the feature is working as expected using the latest version
> of DAMON user-space tool, like below.
>
> $ # start DAMOS for reclaiming memory aiming 30% free memory
> $ sudo ./damo/damo start --damos_action pageout \
> --damos_quota_goal_tuner temporal \
> --damos_quota_goal node_mem_free_bp 30% 0 \
> --damos_quota_interval 1s \
> --damos_quota_space 100M
>
> Note that >=3.1.8 version of DAMON user-space tool supports this feature
> (--damos_quota_goal_tuner). As expected, DAMOS stops reclaiming memory
> as soon as the goal amount of free memory is made. When 'consist' tuner
> is used, the reclamation was continued even after the goal amount of
> free memory is made, resulting in more than goal amount of free memory,
> as expected.
>
> Patch Sequence
> ==============
>
> First four patches implement the features. Patch 1 extends core API to
> allow multiple tuners and make the current tuner as the default and only
> available tuner, namely 'consist'. Patch 2 allows future tuners setting
> zero effective quota. Patch 3 introduces the second tuner, namely
> 'temporal'. Patch 4 further extends DAMON sysfs API to let users use
> that.
>
> Three following patches (patches 5-7) update design, usage, and ABI
> documents, respectively.
>
> Final three patches (patches 8-10) are for adding selftests. The eighth
> and the ninth patches extend the testing-purpose DAMON sysfs control
> helper and DAMON status dumping tool to support the newly added feature.
> The tenth patch extends the existing online commit test to cover the new
> feature.
>
> References
> ==========
>
> [1] https://lore.kernel.org/CALa+Y17__d=ZsM1yX+MXx0ozVdsXnFqF4p0g+kATEitrWyZFfg@mail.gmail.com
> [2] https://lore.kernel.org/20260204022537.814-1-yunjeong.mun@sk.com
>
> Changelog
> =========
>
> Changes from RFC v1
> (https://lore.kernel.org/20260212062314.69961-1-sj@kernel.org)
> - Add selftest for goal_tuner commitment.
> - Set goal tuner inside damon_new_scheme().
> - Allow zero size effective size quota.
> - Update the ABI document.
> - Wordsmith change descriptions.
>
> SeongJae Park (10):
> mm/damon/core: introduce damos_quota_goal_tuner
> mm/damon/core: allow quota goals set zero effective size quota
> mm/damon/core: introduce DAMOS_QUOTA_GOAL_TUNER_TEMPORAL
> mm/damon/sysfs-schemes: implement quotas->goal_tuner file
> Docs/mm/damon/design: document the goal-based quota tuner selections
> Docs/admin-guide/mm/damon/usage: document goal_tuner sysfs file
> Docs/ABI/damon: update for goal_tuner
> selftests/damon/_damon_sysfs: support goal_tuner setup
> selftests/damon/drgn_dump_damon_status: support quota goal_tuner
> dumping
> selftests/damon/sysfs.py: test goal_tuner commit
>
> .../ABI/testing/sysfs-kernel-mm-damon | 6 ++
> Documentation/admin-guide/mm/damon/usage.rst | 16 +++--
> Documentation/mm/damon/design.rst | 12 ++++
> include/linux/damon.h | 11 ++++
> mm/damon/core.c | 60 +++++++++++++++----
> mm/damon/sysfs-schemes.c | 58 ++++++++++++++++++
> tools/testing/selftests/damon/_damon_sysfs.py | 12 +++-
> .../selftests/damon/drgn_dump_damon_status.py | 1 +
> tools/testing/selftests/damon/sysfs.py | 7 +++
> 9 files changed, 166 insertions(+), 17 deletions(-)
>
>
> base-commit: bbba4ca6322dd5c4f66fe31b1b374f77a8d2b2e5
--
Asier Gutierrez
Huawei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms
2026-03-04 10:15 ` [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms Gutierrez Asier
@ 2026-03-04 15:03 ` SeongJae Park
0 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2026-03-04 15:03 UTC (permalink / raw)
To: Gutierrez Asier
Cc: SeongJae Park, Liam R. Howlett, Andrew Morton, David Hildenbrand,
Jonathan Corbet, Lorenzo Stoakes, Michal Hocko, Mike Rapoport,
Shuah Khan, Shuah Khan, Suren Baghdasaryan, Vlastimil Babka,
damon, linux-doc, linux-kernel, linux-kselftest, linux-mm
On Wed, 4 Mar 2026 13:15:29 +0300 Gutierrez Asier <gutierrez.asier@huawei-partners.com> wrote:
> Hi SeongJae!
>
> Nice idea for dynamic environments.
Thank you :)
>
> On 3/4/2026 7:41 AM, SeongJae Park wrote:
> > Aim-oriented DAMOS quota auto-tuning uses a single tuning algorithm.
> > The algorithm is designed to find a quota value that should be
> > consistently kept for achieving the aimed goal for long term. It is
> > useful and reliable at automatically operating systems that have dynamic
> > environments in the long term.
> >
> > As always, however, no single algorithm fits all. When the environment
> > has static characteristics or there are control towers in not only the
> > kernel space but also the user space, the algorithm shows some
> > limitations. In such environments, users want kernel work in a more
> > short term deterministic way. Actually there were at least two reports
> > [1,2] of such cases.
> >
> > Extend DAMOS quotas goal to support multiple quota tuning algorithms
> > that users can select. Keep the current algorithm as the default one,
> > to not break the old users. Also give it a name, "consist", as it is
> > designed to "consistently" apply the DAMOS action. And introduce a new
> > tuning algorithm, namely "temporal". It is designed to apply the DAMOS
> > action only temporally, in a deterministic way. In more detail, as long
> > as the goal is under-achieved, it uses the maximum quota available.
> > Once the goal is over-achieved, it sets the quota zero.
>
> I'm not sure "temporal" is the best name for this type of behaviour.
I agree there could be a better name.
>
> How about "by_score?". For example, "damos_goal_tune_esz_bp_by_score" and
> DAMOS_QUOTA_GOAL_TUNER_BY_SCORE.
And thank you for the suggestion!
But... I don't think "by_score" is much better, because all tuners are assumed
to, and actually do the tuning of the quota based on the score. Or, maybe you
mean it makes non-zero quota only until the score becomes the goal? That makes
sense, but again, in a sense, that's same for "consistent" tuner.
Naming is difficult...
I was also thinking about a few more names, but my conclusion after the self
discussion was that some of ambitious names are inevitable here. Otherwise,
the name will be too long. I therefore picked the shortest and simplest ones
on my list, which at least contrasts the current two tuners. I agree that
could still be difficult to understand. But as long as there is a good
documentation, I think difficult-to-understnd names that encourage users to
read the document is ok and might even be better in some cases.
I'm of course open to other suggestions.
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms
2026-03-04 4:41 [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms SeongJae Park
` (3 preceding siblings ...)
2026-03-04 10:15 ` [RFC PATCH v2 00/10] mm/damon: support multiple goal-based quota tuning algorithms Gutierrez Asier
@ 2026-03-07 0:33 ` SeongJae Park
4 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2026-03-07 0:33 UTC (permalink / raw)
To: SeongJae Park
Cc: Liam R. Howlett, Andrew Morton, David Hildenbrand,
Jonathan Corbet, Lorenzo Stoakes, Michal Hocko, Mike Rapoport,
Shuah Khan, Shuah Khan, Suren Baghdasaryan, Vlastimil Babka,
damon, linux-doc, linux-kernel, linux-kselftest, linux-mm
On Tue, 3 Mar 2026 20:41:09 -0800 SeongJae Park <sj@kernel.org> wrote:
> Aim-oriented DAMOS quota auto-tuning uses a single tuning algorithm.
> The algorithm is designed to find a quota value that should be
> consistently kept for achieving the aimed goal for long term. It is
> useful and reliable at automatically operating systems that have dynamic
> environments in the long term.
>
> As always, however, no single algorithm fits all. When the environment
> has static characteristics or there are control towers in not only the
> kernel space but also the user space, the algorithm shows some
> limitations. In such environments, users want kernel work in a more
> short term deterministic way. Actually there were at least two reports
> [1,2] of such cases.
>
> Extend DAMOS quotas goal to support multiple quota tuning algorithms
> that users can select. Keep the current algorithm as the default one,
> to not break the old users. Also give it a name, "consist", as it is
> designed to "consistently" apply the DAMOS action. And introduce a new
> tuning algorithm, namely "temporal". It is designed to apply the DAMOS
> action only temporally, in a deterministic way. In more detail, as long
> as the goal is under-achieved, it uses the maximum quota available.
> Once the goal is over-achieved, it sets the quota zero.
>
> Tests
> =====
>
> I confirmed the feature is working as expected using the latest version
> of DAMON user-space tool, like below.
>
> $ # start DAMOS for reclaiming memory aiming 30% free memory
> $ sudo ./damo/damo start --damos_action pageout \
> --damos_quota_goal_tuner temporal \
> --damos_quota_goal node_mem_free_bp 30% 0 \
> --damos_quota_interval 1s \
> --damos_quota_space 100M
>
> Note that >=3.1.8 version of DAMON user-space tool supports this feature
> (--damos_quota_goal_tuner). As expected, DAMOS stops reclaiming memory
> as soon as the goal amount of free memory is made. When 'consist' tuner
> is used, the reclamation was continued even after the goal amount of
> free memory is made, resulting in more than goal amount of free memory,
> as expected.
>
> Patch Sequence
> ==============
>
> First four patches implement the features. Patch 1 extends core API to
> allow multiple tuners and make the current tuner as the default and only
> available tuner, namely 'consist'. Patch 2 allows future tuners setting
> zero effective quota. Patch 3 introduces the second tuner, namely
> 'temporal'. Patch 4 further extends DAMON sysfs API to let users use
> that.
>
> Three following patches (patches 5-7) update design, usage, and ABI
> documents, respectively.
>
> Final three patches (patches 8-10) are for adding selftests. The eighth
> and the ninth patches extend the testing-purpose DAMON sysfs control
> helper and DAMON status dumping tool to support the newly added feature.
> The tenth patch extends the existing online commit test to cover the new
> feature.
>
> References
> ==========
>
> [1] https://lore.kernel.org/CALa+Y17__d=ZsM1yX+MXx0ozVdsXnFqF4p0g+kATEitrWyZFfg@mail.gmail.com
> [2] https://lore.kernel.org/20260204022537.814-1-yunjeong.mun@sk.com
>
> Changelog
> =========
>
> Changes from RFC v1
> (https://lore.kernel.org/20260212062314.69961-1-sj@kernel.org)
> - Add selftest for goal_tuner commitment.
> - Set goal tuner inside damon_new_scheme().
> - Allow zero size effective size quota.
> - Update the ABI document.
> - Wordsmith change descriptions.
>
> SeongJae Park (10):
> mm/damon/core: introduce damos_quota_goal_tuner
> mm/damon/core: allow quota goals set zero effective size quota
> mm/damon/core: introduce DAMOS_QUOTA_GOAL_TUNER_TEMPORAL
> mm/damon/sysfs-schemes: implement quotas->goal_tuner file
> Docs/mm/damon/design: document the goal-based quota tuner selections
> Docs/admin-guide/mm/damon/usage: document goal_tuner sysfs file
> Docs/ABI/damon: update for goal_tuner
> selftests/damon/_damon_sysfs: support goal_tuner setup
> selftests/damon/drgn_dump_damon_status: support quota goal_tuner
> dumping
> selftests/damon/sysfs.py: test goal_tuner commit
Maybe it is better to add a kunit test for the goal_tuner online commit, like
below. I will add it to the next spin of this series.
Thanks,
SJ
[...]
=== >8 ===
From 15d87f41d0d960e3c337899629cf4e05d09dc042 Mon Sep 17 00:00:00 2001
From: SeongJae Park <sj@kernel.org>
Date: Fri, 6 Mar 2026 16:27:45 -0800
Subject: [PATCH] mm/damon/tests/core-kunit: test goal_tuner commit
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/tests/core-kunit.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index d759314df00d8..28e5de749db04 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -791,6 +791,7 @@ static void damos_test_commit_quota(struct kunit *test)
.reset_interval = 1,
.ms = 2,
.sz = 3,
+ .goal_tuner = DAMOS_QUOTA_GOAL_TUNER_CONSIST,
.weight_sz = 4,
.weight_nr_accesses = 5,
.weight_age = 6,
@@ -799,6 +800,7 @@ static void damos_test_commit_quota(struct kunit *test)
.reset_interval = 7,
.ms = 8,
.sz = 9,
+ .goal_tuner = DAMOS_QUOTA_GOAL_TUNER_TEMPORAL,
.weight_sz = 10,
.weight_nr_accesses = 11,
.weight_age = 12,
@@ -812,6 +814,7 @@ static void damos_test_commit_quota(struct kunit *test)
KUNIT_EXPECT_EQ(test, dst.reset_interval, src.reset_interval);
KUNIT_EXPECT_EQ(test, dst.ms, src.ms);
KUNIT_EXPECT_EQ(test, dst.sz, src.sz);
+ KUNIT_EXPECT_EQ(test, dst.goal_tuner, src.goal_tuner);
KUNIT_EXPECT_EQ(test, dst.weight_sz, src.weight_sz);
KUNIT_EXPECT_EQ(test, dst.weight_nr_accesses, src.weight_nr_accesses);
KUNIT_EXPECT_EQ(test, dst.weight_age, src.weight_age);
--
2.47.3
^ permalink raw reply related [flat|nested] 7+ messages in thread