Linux Kernel Selftest development
 help / color / mirror / Atom feed
* [PATCH 1/2] kunit: config: Enable KUNIT_DEBUGFS by default
@ 2026-04-25  3:41 David Gow
  2026-04-25  3:41 ` [PATCH 2/2] kunit: config: KUNIT_DEBUGFS should depend on DEBUG_FS David Gow
  0 siblings, 1 reply; 2+ messages in thread
From: David Gow @ 2026-04-25  3:41 UTC (permalink / raw)
  To: Brendan Higgins, Rae Moar, Shuah Khan
  Cc: David Gow, Alan Maguire, Anders Roxell, linux-kselftest,
	kunit-dev, linux-kernel

The KUNIT_DEBUGFS option is currently enabled based on the value of
KUNIT_ALL_TESTS, but it really doesn't have anything to do with the set of
enabled tests, so just enable it by default anyway. In particular, this
shouldn't be only visible if KUNIT_ALL_TESTS is set, which is quite
confusing.

Fixes: beaed42c427d ("kunit: default KUNIT_* fragments to KUNIT_ALL_TESTS")
Signed-off-by: David Gow <david@davidgow.net>
---
 lib/kunit/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/kunit/Kconfig b/lib/kunit/Kconfig
index 498cc51e493d..f80ca3aeedb0 100644
--- a/lib/kunit/Kconfig
+++ b/lib/kunit/Kconfig
@@ -16,8 +16,8 @@ menuconfig KUNIT
 if KUNIT
 
 config KUNIT_DEBUGFS
-	bool "KUnit - Enable /sys/kernel/debug/kunit debugfs representation" if !KUNIT_ALL_TESTS
-	default KUNIT_ALL_TESTS
+	bool "KUnit - Enable /sys/kernel/debug/kunit debugfs representation"
+	default y
 	help
 	  Enable debugfs representation for kunit.  Currently this consists
 	  of /sys/kernel/debug/kunit/<test_suite>/results files for each
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 2/2] kunit: config: KUNIT_DEBUGFS should depend on DEBUG_FS
  2026-04-25  3:41 [PATCH 1/2] kunit: config: Enable KUNIT_DEBUGFS by default David Gow
@ 2026-04-25  3:41 ` David Gow
  0 siblings, 0 replies; 2+ messages in thread
From: David Gow @ 2026-04-25  3:41 UTC (permalink / raw)
  To: Brendan Higgins, Rae Moar, Shuah Khan
  Cc: David Gow, Alan Maguire, Anders Roxell, linux-kselftest,
	kunit-dev, linux-kernel

CONFIG_KUNIT_DEBUGFS is totally useless without debugfs, so it should
depend on CONFIG_DEBUG_FS.

Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
Signed-off-by: David Gow <david@davidgow.net>
---
 lib/kunit/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/kunit/Kconfig b/lib/kunit/Kconfig
index f80ca3aeedb0..94ff8e4089bf 100644
--- a/lib/kunit/Kconfig
+++ b/lib/kunit/Kconfig
@@ -17,6 +17,7 @@ if KUNIT
 
 config KUNIT_DEBUGFS
 	bool "KUnit - Enable /sys/kernel/debug/kunit debugfs representation"
+	depends on DEBUG_FS
 	default y
 	help
 	  Enable debugfs representation for kunit.  Currently this consists
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-25  3:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-25  3:41 [PATCH 1/2] kunit: config: Enable KUNIT_DEBUGFS by default David Gow
2026-04-25  3:41 ` [PATCH 2/2] kunit: config: KUNIT_DEBUGFS should depend on DEBUG_FS David Gow

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox