* [PATCH] selftests: net: fcnal-test.sh: rmmod br_netfilter at function exit
@ 2026-06-10 14:46 Paolo Pisati
2026-06-10 14:56 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Pisati @ 2026-06-10 14:46 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, Shuah Khan, linux-kselftest
Cc: Paolo Pisati
fcnal-test.sh loads br_netfilter to test bridge-into-VRF scenarios but
does not remove it at function exit (the second modprobe around line 4158
has no matching rmmod). Since tests run sequentially, any test running
after fcnal-test.sh inherits it.
Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
---
tools/testing/selftests/net/fcnal-test.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
index 890c3f8e51bb..de7b6768882a 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -4176,6 +4176,8 @@ use_case_br()
setup_cmd ip li del br0 2>/dev/null
setup_cmd_nsb ip li del vlan100 2>/dev/null
+
+ rmmod br_netfilter 2>/dev/null
}
# VRF only.
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: net: fcnal-test.sh: rmmod br_netfilter at function exit
2026-06-10 14:46 [PATCH] selftests: net: fcnal-test.sh: rmmod br_netfilter at function exit Paolo Pisati
@ 2026-06-10 14:56 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2026-06-10 14:56 UTC (permalink / raw)
To: Paolo Pisati
Cc: David S . Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
Shuah Khan, linux-kselftest
On Wed, 10 Jun 2026 16:46:18 +0200 Paolo Pisati wrote:
> fcnal-test.sh loads br_netfilter to test bridge-into-VRF scenarios but
> does not remove it at function exit (the second modprobe around line 4158
> has no matching rmmod). Since tests run sequentially, any test running
> after fcnal-test.sh inherits it.
And why is that a problem? As a general rule tests shouldn't unload the
modules they loaded cause something else may have started using them.
Also you did not CC netdev@ on this.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-10 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 14:46 [PATCH] selftests: net: fcnal-test.sh: rmmod br_netfilter at function exit Paolo Pisati
2026-06-10 14:56 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox