From: Mina Almasry <almasrymina@google.com>
To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Mina Almasry <almasrymina@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Bobby Eshleman <bobbyeshleman@meta.com>
Subject: [PATCH net-next v2 2/2] selftests: drv-net: ncdevmem: gracefully retry bind()
Date: Mon, 3 Aug 2026 18:18:26 +0000 [thread overview]
Message-ID: <20260803181852.491437-2-almasrymina@google.com> (raw)
In-Reply-To: <20260803181852.491437-1-almasrymina@google.com>
During tests, ethnl_rings_set randomly bounces the link causing a
transient IPv6 Duplicate Address Detection "tentative" race, resulting
in spurious -EADDRNOTAVAIL aborts inside the ncdevmem server.
Add a simple 10 second retry loop around bind() to absorb the link bounce.
Signed-off-by: Mina Almasry <almasrymina@google.com>
---
v2:
- Refactored C99 mid-scope variables to strictly adhere to C89 styling.
- Dropped single-line curly brace avoidance syntax.
v1: https://patchwork.kernel.org/project/netdevbpf/patch/20260801131220.1367229-2-almasrymina@google.com/
---
tools/testing/selftests/drivers/net/hw/ncdevmem.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/hw/ncdevmem.c b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
index ffe1d5c1fa4e1..67901a0123e8c 100644
--- a/tools/testing/selftests/drivers/net/hw/ncdevmem.c
+++ b/tools/testing/selftests/drivers/net/hw/ncdevmem.c
@@ -843,6 +843,7 @@ static int do_server(struct memory_buffer *mem)
char iobuf[819200];
int ret, err = -1;
char buffer[256];
+ int retries = 10;
int socket_fd;
int client_fd;
@@ -898,7 +899,12 @@ static int do_server(struct memory_buffer *mem)
fprintf(stderr, "binding to address %s:%d\n", server_ip,
ntohs(server_sin.sin6_port));
- ret = bind(socket_fd, &server_sin, sizeof(server_sin));
+ while (retries--) {
+ ret = bind(socket_fd, &server_sin, sizeof(server_sin));
+ if (!ret)
+ break;
+ sleep(1);
+ }
if (ret) {
pr_err("Failed to bind");
goto err_close_socket;
--
2.55.0.571.g244d577d93-goog
next prev parent reply other threads:[~2026-08-03 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 18:18 [PATCH net-next v2 1/2] selftests: drv-net: devmem: fix 5-tuple flow steering Mina Almasry
2026-08-03 18:18 ` Mina Almasry [this message]
2026-08-06 19:16 ` [PATCH net-next v2 2/2] selftests: drv-net: ncdevmem: gracefully retry bind() Jakub Kicinski
2026-08-06 19:27 ` Mina Almasry
2026-08-06 19:16 ` [PATCH net-next v2 1/2] selftests: drv-net: devmem: fix 5-tuple flow steering Jakub Kicinski
2026-08-06 20:05 ` Mina Almasry
2026-08-06 20:34 ` Jakub Kicinski
2026-08-06 20:59 ` Mina Almasry
2026-08-07 21:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803181852.491437-2-almasrymina@google.com \
--to=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox