From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Bobby Eshleman <bobbyeshleman@meta.com>
Subject: Re: [PATCH net-next v2 1/2] selftests: drv-net: devmem: fix 5-tuple flow steering
Date: Fri, 7 Aug 2026 14:54:44 -0700 [thread overview]
Message-ID: <20260807145444.6acf9c08@kernel.org> (raw)
In-Reply-To: <CAHS8izOU2pxfQH0Wo1DrqajOb54wv3Y1rMryGpwjNnoUsEufew@mail.gmail.com>
On Thu, 6 Aug 2026 13:59:53 -0700 Mina Almasry wrote:
> Do you mean forking all the test cases so that we have
> check_rx_3_tuple and check_rx_5_tuple, etc? Won't that be annoying in
> the future if every test case needs to be duplicated twice? And
> potentially again if there is another deviation in driver config
> support specifics?
No no, I just meant a trivial test that installs the rule and maybe
sends a packet to check via getsockopt(NAPI_ID) that it arrived on
the right queue.
You can probably extend ntuple.py instead. I was thinking yesterday
that it's nice to have all zcrx stuff in one place. But in reality
we already have a bunch of scripts testing zcrx so ntuple.py is
probably better.
prev parent reply other threads:[~2026-08-07 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 18:18 [PATCH net-next v2 1/2] selftests: drv-net: devmem: fix 5-tuple flow steering Mina Almasry
2026-08-03 18:18 ` [PATCH net-next v2 2/2] selftests: drv-net: ncdevmem: gracefully retry bind() Mina Almasry
2026-08-06 19:16 ` Jakub Kicinski
2026-08-06 19:27 ` Mina Almasry
2026-08-06 19:16 ` [PATCH net-next v2 1/2] selftests: drv-net: devmem: fix 5-tuple flow steering Jakub Kicinski
2026-08-06 20:05 ` Mina Almasry
2026-08-06 20:34 ` Jakub Kicinski
2026-08-06 20:59 ` Mina Almasry
2026-08-07 21:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807145444.6acf9c08@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox