Linux Kernel Selftest development
 help / color / mirror / Atom feed
* [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m
@ 2026-08-24 15:14 Geert Uytterhoeven
  2026-08-25  8:01 ` Christoph Hellwig
  2026-08-25  8:32 ` Ard Biesheuvel
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2026-08-24 15:14 UTC (permalink / raw)
  To: Christoph Hellwig, Andrew Morton, Eric Biggers, Ard Biesheuvel
  Cc: linux-kselftest, linux-kernel, Geert Uytterhoeven

Enabling the (possibly long-running benchmarks) by default may cause a
big delay in boot time in case of built-in tests.  However, they can
still safely be enabled by default if all tests are modular, as they
would only run when requested explicitly by the system administrator.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 lib/raid/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/raid/Kconfig b/lib/raid/Kconfig
index 01f007b2522cfc33..563a178aa930c420 100644
--- a/lib/raid/Kconfig
+++ b/lib/raid/Kconfig
@@ -32,6 +32,7 @@ config XOR_KUNIT_TEST
 config XOR_BENCHMARK
 	bool "Benchmark for xor_gen"
 	depends on XOR_KUNIT_TEST
+	default y if KUNIT_ALL_TESTS=m
 	help
 	  Include benchmarks in the KUnit test suite for xor_gen.
 
@@ -63,6 +64,7 @@ config RAID6_PQ_KUNIT_TEST
 config RAID6_PQ_KUNIT_BENCHMARK
 	bool "Benchmark for RAID6 PQ"
 	depends on RAID6_PQ_KUNIT_TEST
+	default y if KUNIT_ALL_TESTS=m
 	help
 	  Include benchmarks in the KUnit test suite for raid P/Q generation.
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m
  2026-08-24 15:14 [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m Geert Uytterhoeven
@ 2026-08-25  8:01 ` Christoph Hellwig
  2026-08-25  8:32 ` Ard Biesheuvel
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2026-08-25  8:01 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Christoph Hellwig, Andrew Morton, Eric Biggers, Ard Biesheuvel,
	linux-kselftest, linux-kernel

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m
  2026-08-24 15:14 [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m Geert Uytterhoeven
  2026-08-25  8:01 ` Christoph Hellwig
@ 2026-08-25  8:32 ` Ard Biesheuvel
  1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2026-08-25  8:32 UTC (permalink / raw)
  To: Geert Uytterhoeven, Christoph Hellwig, Andrew Morton,
	Eric Biggers
  Cc: linux-kselftest, linux-kernel


On Mon, 24 Aug 2026, at 17:14, Geert Uytterhoeven wrote:
> Enabling the (possibly long-running benchmarks) by default may cause a
> big delay in boot time in case of built-in tests.  However, they can
> still safely be enabled by default if all tests are modular, as they
> would only run when requested explicitly by the system administrator.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  lib/raid/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-25  8:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-24 15:14 [PATCH] raid/kunit: Enable RAID6 PQ and XOR benchmarks if KUNIT_ALL_TESTS=m Geert Uytterhoeven
2026-08-25  8:01 ` Christoph Hellwig
2026-08-25  8:32 ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox