* [RFC PATCH v1.3 0/4] mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms
@ 2026-08-28 18:36 SJ Park
2026-08-28 18:36 ` [RFC PATCH v1.3 1/4] mm/damon/tests/core-kunit: test committing psi goal to psi goal SJ Park
0 siblings, 1 reply; 2+ messages in thread
From: SJ Park @ 2026-08-28 18:36 UTC (permalink / raw)
Cc: SJ Park, stable, Andrew Morton, Brendan Higgins, David Gow,
Quanmin Yan, Ravi Jonnalagadda, damon, kunit-dev, linux-kernel,
linux-kselftest, linux-mm
DAMOS quota goals commit unit test is mistakenly not testing a test case
that was designed to test. DAMOS quota goals and DAMON sysfs refresh_ms
file have bugs that can produce non critical but still unexpected
behaviors. Fix the bugs.
Patch 1 fixes the DAMOS quota goals commit unit test to cover a
mistakenly uncovered case. Patches 2 and 3 fix the bugs in DAMOS PSI
goal initialization and eligible_mem_bp online commit, respectively.
Patch 4 fixes the bug in DAMON sysfs refresh_ms file handling.
Changes from RFC v1.2
- RFC v1.2: https://lore.kernel.org/20260828014659.121058-1-sj@kernel.org
- Fix last_psi_total underflow.
Changes from RFC v1.1
- RFC v1.1: https://lore.kernel.org/20260827134429.123023-1-sj@kernel.org
- Fix quota goals commit unit test that was mistakenly missing a test case.
- Initialize last_psi_total as uninitialized at the beginning.
- Correct kunit test for changed last_psi_total initialization behavior.
Changes from RFC
- RFC: https://lore.kernel.org/20260827042920.93580-1-sj@kernel.org
(Mistakenly missed RFC tag)
- Fix build error.
- Add eligible_mem_bp nid commit fix.
SJ Park (4):
mm/damon/tests/core-kunit: test committing psi goal to psi goal
mm/damon/core: handle uninitialized damos_quota_goal->last_psi_total
mm/damon/core: copy nid for eligible_mem_bp damos quota goal commit
mm/damon/sysfs: set next refresh jiffies per sysfs context
mm/damon/core.c | 16 ++++++++++++++--
mm/damon/sysfs.c | 11 +++++------
mm/damon/tests/core-kunit.h | 16 ++++++++++------
3 files changed, 29 insertions(+), 14 deletions(-)
base-commit: f508ed0a3bc67ac2a17ba4eaa7f219a95f6b3954
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* [RFC PATCH v1.3 1/4] mm/damon/tests/core-kunit: test committing psi goal to psi goal
2026-08-28 18:36 [RFC PATCH v1.3 0/4] mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms SJ Park
@ 2026-08-28 18:36 ` SJ Park
0 siblings, 0 replies; 2+ messages in thread
From: SJ Park @ 2026-08-28 18:36 UTC (permalink / raw)
Cc: SJ Park, stable, Andrew Morton, Brendan Higgins, David Gow, damon,
kunit-dev, linux-kernel, linux-kselftest, linux-mm
damon_test_commit_quota_goal_for() is set to test committing a new psi
goal on an existing psi goal. However, damon_test_commit_quota_goal()
is mistakenly not covering the test case. Add the test case.
Fixes: 99f89debafc5 ("mm/damon/tests/core-kunit: add damos_commit_quota_goal() test")
Cc: <stable@vger.kernel.org> # 6.19.x
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/tests/core-kunit.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 4a536d41cdb2d..b643f9a83f14a 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -787,6 +787,13 @@ static void damos_test_commit_quota_goal(struct kunit *test)
.last_psi_total = 456,
};
+ damos_test_commit_quota_goal_for(test, &dst,
+ &(struct damos_quota_goal) {
+ .metric = DAMOS_QUOTA_SOME_MEM_PSI_US,
+ .target_value = 234,
+ .current_value = 345,
+ .last_psi_total = 567,
+ });
damos_test_commit_quota_goal_for(test, &dst,
&(struct damos_quota_goal){
.metric = DAMOS_QUOTA_USER_INPUT,
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-28 18:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-28 18:36 [RFC PATCH v1.3 0/4] mm/damon: fix misc bugs in kunit, quota goals and sysfs refresh_ms SJ Park
2026-08-28 18:36 ` [RFC PATCH v1.3 1/4] mm/damon/tests/core-kunit: test committing psi goal to psi goal SJ Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox