From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <hangbin.liu@linux.dev>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Hangbin Liu <liuhangbin@kylinos.cn>
Subject: Re: [PATCH net-next 1/2] netdevsim: add link speed support
Date: Mon, 31 Aug 2026 15:08:18 -0700 [thread overview]
Message-ID: <20260831150818.660de896@kernel.org> (raw)
In-Reply-To: <20260831-nsim_speed-v1-1-7a651ee65738@kylinos.cn>
On Mon, 31 Aug 2026 11:28:10 +0800 Hangbin Liu wrote:
> Add ethtool get/set_link_ksettings callbacks to netdevsim so the simulated
> link speed and duplex can be queried and configured from userspace.
>
> Move NSIM_LINK_SPEED_MAX and NSIM_LINK_SPEED_UNIT from dev.c to netdevsim.h
> so they are available to both the devlink rate path and the new ethtool
> code. The set callback rejects speeds exceeding NSIM_LINK_SPEED_MAX.
>
> The default link speed is set to SPEED_5000 with DUPLEX_FULL, matching the
> existing NSIM_LINK_SPEED_MAX definition.
This breaks TDC which uses netdevsim for taprio testing.
You posted 2 series for net-next and both broke tests.
Please try harder to test stuff locally.
Matt added support for Docker to NIPA so you should be able
to repro all ksfts locally. If something doesn't work please
report back.
next prev parent reply other threads:[~2026-08-31 22:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 3:28 [PATCH net-next 0/2] netdevsim: add link speed support Hangbin Liu
2026-08-31 3:28 ` [PATCH net-next 1/2] " Hangbin Liu
2026-08-31 12:16 ` Andrew Lunn
2026-09-01 6:39 ` Hangbin Liu
2026-09-01 12:43 ` Andrew Lunn
2026-09-02 1:53 ` Hangbin Liu
2026-09-02 12:38 ` Andrew Lunn
2026-08-31 12:24 ` Andrew Lunn
2026-09-01 6:31 ` Hangbin Liu
2026-08-31 22:08 ` Jakub Kicinski [this message]
2026-09-01 6:58 ` Hangbin Liu
2026-09-01 8:23 ` Hangbin Liu
2026-09-01 14:21 ` Andrew Lunn
2026-09-02 2:01 ` Hangbin Liu
2026-09-02 12:49 ` Andrew Lunn
2026-09-01 14:18 ` Andrew Lunn
2026-08-31 3:28 ` [PATCH net-next 2/2] selftests: netdevsim: add speed testing Hangbin Liu
2026-08-31 22:06 ` Jakub Kicinski
2026-09-01 6:42 ` Hangbin Liu
2026-09-01 15:06 ` Jakub Kicinski
2026-09-02 2:04 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831150818.660de896@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hangbin.liu@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox