From: Hangbin Liu <hangbin.liu@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Hangbin Liu <liuhangbin@kylinos.cn>
Subject: Re: [PATCH net-next 2/2] selftests: netdevsim: add speed testing
Date: Tue, 1 Sep 2026 14:42:06 +0800 [thread overview]
Message-ID: <apZzvvEQPNHTT26c@fedora> (raw)
In-Reply-To: <20260831150642.68f28691@kernel.org>
On Mon, Aug 31, 2026 at 03:06:42PM -0700, Jakub Kicinski wrote:
> On Mon, 31 Aug 2026 11:28:11 +0800 Hangbin Liu wrote:
> > Add a script for netdevsim speed test. Make sure the speed and duplex
> > could be changed. And the speed can't be larger than the max speed.
>
> nak, this is not a meaningful test
OK, I thought we should add selftests for new features. And there are
netdevsim ethtool tests like ethtool-pause.sh. Since you think this test
is meaningless. I will drop it in next version.
Hangbin
next prev parent reply other threads:[~2026-09-01 6:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 3:28 [PATCH net-next 0/2] netdevsim: add link speed support Hangbin Liu
2026-08-31 3:28 ` [PATCH net-next 1/2] " Hangbin Liu
2026-08-31 12:16 ` Andrew Lunn
2026-09-01 6:39 ` Hangbin Liu
2026-09-01 12:43 ` Andrew Lunn
2026-09-02 1:53 ` Hangbin Liu
2026-09-02 12:38 ` Andrew Lunn
2026-08-31 12:24 ` Andrew Lunn
2026-09-01 6:31 ` Hangbin Liu
2026-08-31 22:08 ` Jakub Kicinski
2026-09-01 6:58 ` Hangbin Liu
2026-09-01 8:23 ` Hangbin Liu
2026-09-01 14:21 ` Andrew Lunn
2026-09-02 2:01 ` Hangbin Liu
2026-09-02 12:49 ` Andrew Lunn
2026-09-01 14:18 ` Andrew Lunn
2026-08-31 3:28 ` [PATCH net-next 2/2] selftests: netdevsim: add speed testing Hangbin Liu
2026-08-31 22:06 ` Jakub Kicinski
2026-09-01 6:42 ` Hangbin Liu [this message]
2026-09-01 15:06 ` Jakub Kicinski
2026-09-02 2:04 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apZzvvEQPNHTT26c@fedora \
--to=hangbin.liu@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox