Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Jimmy Zuber <jamz@amazon.com>
To: NeilBrown <neil@brown.name>
Cc: Miklos Szeredi <miklos@szeredi.hu>, <fuse-devel@lists.linux.dev>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
	"Bernd Schubert" <bernd@bsbernd.com>,
	Jim Harris <jiharris@nvidia.com>,
	"Horst Birthelmer" <horst@birthelmer.de>,
	Luis Henriques <luis@igalia.com>
Subject: Re: [PATCH 1/3] fuse: add FUSE_OPEN_ATOMIC
Date: Thu, 22 Oct 2026 01:45:45 +0000	[thread overview]
Message-ID: <20261022014545.2495106-1-jamz@amazon.com> (raw)
In-Reply-To: <179253863737.1724252.12836488084615923712@noble.neil.brown.name>

On Wed, 21 Oct 2026, NeilBrown wrote:
> > +	d_drop(entry);
> > +	res = d_splice_alias(inode, entry);
>
> As of f1ac607f786f d_splice_alias() handles hashed dentries
> and the d_drop() is not needed and not wanted.

Thanks. I'll rebase onto 7.4-rc1 (will make note of the dependency), which
has the commit f1ac607f786f.

> > -	d_instantiate(entry, inode);
> > +	if (d_in_lookup(entry))
> > +		d_splice_alias(inode, entry);
> > +	else
> > +		d_instantiate(entry, inode);
>
> Similar to above, d_splice_alias() is now sufficient for all cases.

Thanks, fuse_create_open() also handles FUSE_TMPFILE, which needs
d_instantiate() for its dentry to stay unhashed. Otherwise I can have it use
d_splice_alias().

  reply	other threads:[~2026-10-22  1:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 14:16 [PATCH 0/3] fuse: atomic open jamz
2026-10-20 14:16 ` [PATCH 1/3] fuse: add FUSE_OPEN_ATOMIC jamz
2026-10-20 23:23   ` NeilBrown
2026-10-22  1:45     ` Jimmy Zuber [this message]
2026-10-22  5:26       ` NeilBrown
2026-10-20 14:16 ` [PATCH 2/3] fuse: open cached files with FUSE_OPEN_ATOMIC jamz
2026-10-20 14:16 ` [PATCH 3/3] selftests/fuse: add test for FUSE_OPEN_ATOMIC jamz
2026-10-20 23:33 ` [PATCH 0/3] fuse: atomic open NeilBrown
2026-10-22  1:46   ` Jimmy Zuber
2026-10-22  5:30     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022014545.2495106-1-jamz@amazon.com \
    --to=jamz@amazon.com \
    --cc=bernd@bsbernd.com \
    --cc=fuse-devel@lists.linux.dev \
    --cc=horst@birthelmer.de \
    --cc=jiharris@nvidia.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luis@igalia.com \
    --cc=miklos@szeredi.hu \
    --cc=neil@brown.name \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox