* [PATCH net-next] selftests: net: don't warn when bpftool is missing
@ 2026-11-18 16:53 Maciej Fijalkowski
2026-11-19 1:11 ` Alexei Starovoitov
0 siblings, 1 reply; 5+ messages in thread
From: Maciej Fijalkowski @ 2026-11-18 16:53 UTC (permalink / raw)
To: netdev, bpf
Cc: kuba, ast, daniel, pabeni, edumazet, horms, davem, shuah, hawk,
john.fastabend, sdf, willemb, petrm, bjorn, magnus.karlsson,
linux-kselftest
xskxceiver and xdp_hw_metadata need bpftool to generate their BPF
skeletons, so they are skipped when it is missing or does not work.
The kernel test robot builds selftests without bpftool and reports the
warnings about it as new build regressions in both net-next and
bpf-next. Skipping the two tools is expected there, so drop the
warnings.
Fixes: e8f9d8237988 ("selftests: xsk: move the AF_XDP test suite to selftests/net")
Fixes: d01fb5c81130 ("selftests: net: move xdp_hw_metadata from selftests/bpf")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202611140904.io658Rze-lkp@intel.com/
Closes: https://lore.kernel.org/r/202611141124.V0t6dlFo-lkp@intel.com/
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
Based on the bpf-net-xsk-move tag so it can go to net-next and bpf-next
through another shared branch, as Alexei asked:
https://lore.kernel.org/netdev/CAADnVQK=Y1CY=m0gGegLB-jm9S1cUcEcKUuNx33PT2W-tdMCuw@mail.gmail.com/
tools/testing/selftests/net/Makefile | 2 --
tools/testing/selftests/net/lib/Makefile | 2 --
2 files changed, 4 deletions(-)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 83882735229d..a7f8b2c0b763 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -231,8 +231,6 @@ BPFTOOL ?= bpftool
HAS_BPFTOOL := $(shell $(BPFTOOL) version >/dev/null 2>&1 && echo y)
ifeq ($(HAS_BPFTOOL),y)
COND_GEN_FILES += xdp_hw_metadata
-else
-$(warning excluding xdp_hw_metadata, bpftool not installed or not working)
endif
TEST_GEN_FILES += $(COND_GEN_FILES)
diff --git a/tools/testing/selftests/net/lib/Makefile b/tools/testing/selftests/net/lib/Makefile
index 0a6cd733883d..5765625ae7f7 100644
--- a/tools/testing/selftests/net/lib/Makefile
+++ b/tools/testing/selftests/net/lib/Makefile
@@ -10,8 +10,6 @@ BPFTOOL ?= bpftool
HAS_BPFTOOL := $(shell $(BPFTOOL) version >/dev/null 2>&1 && echo y)
ifeq ($(HAS_BPFTOOL),y)
COND_GEN_FILES += xskxceiver
-else
-$(warning excluding xskxceiver, bpftool not installed or not working)
endif
TEST_FILES := \
base-commit: d01fb5c8113055e3d1b7f573261ae6a30abf4e53
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] selftests: net: don't warn when bpftool is missing
2026-11-18 16:53 [PATCH net-next] selftests: net: don't warn when bpftool is missing Maciej Fijalkowski
@ 2026-11-19 1:11 ` Alexei Starovoitov
2026-11-21 2:03 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Alexei Starovoitov @ 2026-11-19 1:11 UTC (permalink / raw)
To: Maciej Fijalkowski, netdev, bpf
Cc: kuba, daniel, pabeni, edumazet, horms, davem, shuah, hawk,
john.fastabend, sdf, willemb, petrm, bjorn, magnus.karlsson,
linux-kselftest
On Wed, Nov 18, 2026 at 08:53 AM Maciej Fijalkowski <maciej.fijalkowski@intel.com> wrote:
> Based on the bpf-net-xsk-move tag so it can go to net-next and bpf-next
> through another shared branch, as Alexei asked:
Acked-by: Alexei Starovoitov <ast@kernel.org>
Thanks for the quick fix.
Jakub,
could you make another stable branch to pull?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] selftests: net: don't warn when bpftool is missing
2026-11-19 1:11 ` Alexei Starovoitov
@ 2026-11-21 2:03 ` Jakub Kicinski
2026-11-21 2:06 ` Alexei Starovoitov
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2026-11-21 2:03 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: Maciej Fijalkowski, netdev, bpf, daniel, pabeni, edumazet, horms,
davem, shuah, hawk, john.fastabend, sdf, willemb, petrm, bjorn,
magnus.karlsson, linux-kselftest
On Thu, 19 Nov 2026 01:11:08 +0000 Alexei Starovoitov wrote:
> On Wed, Nov 18, 2026 at 08:53 AM Maciej Fijalkowski <maciej.fijalkowski@intel.com> wrote:
> > Based on the bpf-net-xsk-move tag so it can go to net-next and bpf-next
> > through another shared branch, as Alexei asked:
>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
>
> Thanks for the quick fix.
>
> Jakub,
> could you make another stable branch to pull?
Are you sure we need to fix this? Do we care about the bot?
We have a similar warning for having latest version of liburing
in drivers/net. I think it's useful to let the user know that
they are not building all the tests.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] selftests: net: don't warn when bpftool is missing
2026-11-21 2:03 ` Jakub Kicinski
@ 2026-11-21 2:06 ` Alexei Starovoitov
2026-11-21 2:15 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Alexei Starovoitov @ 2026-11-21 2:06 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Maciej Fijalkowski, netdev, bpf, daniel, pabeni, edumazet, horms,
davem, shuah, hawk, john.fastabend, sdf, willemb, petrm, bjorn,
magnus.karlsson, linux-kselftest
On Sat Nov 21, 2026 at 2:03 AM UTC, Jakub Kicinski wrote:
> On Thu, 19 Nov 2026 01:11:08 +0000 Alexei Starovoitov wrote:
>> On Wed, Nov 18, 2026 at 08:53 AM Maciej Fijalkowski <maciej.fijalkowski@intel.com> wrote:
>> > Based on the bpf-net-xsk-move tag so it can go to net-next and bpf-next
>> > through another shared branch, as Alexei asked:
>>
>> Acked-by: Alexei Starovoitov <ast@kernel.org>
>>
>> Thanks for the quick fix.
>>
>> Jakub,
>> could you make another stable branch to pull?
>
> Are you sure we need to fix this? Do we care about the bot?
> We have a similar warning for having latest version of liburing
> in drivers/net. I think it's useful to let the user know that
> they are not building all the tests.
the bot seems to yell every other day 'regression' in capital letters.
I suspect people will notice sooner or later.
If you think it's ok to just ignore it, then let's do that for now.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] selftests: net: don't warn when bpftool is missing
2026-11-21 2:06 ` Alexei Starovoitov
@ 2026-11-21 2:15 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2026-11-21 2:15 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: Maciej Fijalkowski, netdev, bpf, daniel, pabeni, edumazet, horms,
davem, shuah, hawk, john.fastabend, sdf, willemb, petrm, bjorn,
magnus.karlsson, linux-kselftest
On Sat, 21 Nov 2026 02:06:53 +0000 Alexei Starovoitov wrote:
> On Sat Nov 21, 2026 at 2:03 AM UTC, Jakub Kicinski wrote:
> > On Thu, 19 Nov 2026 01:11:08 +0000 Alexei Starovoitov wrote:
> >> On Wed, Nov 18, 2026 at 08:53 AM Maciej Fijalkowski <maciej.fijalkowski@intel.com> wrote:
> [...]
> >>
> >> Acked-by: Alexei Starovoitov <ast@kernel.org>
> >>
> >> Thanks for the quick fix.
> >>
> >> Jakub,
> >> could you make another stable branch to pull?
> >
> > Are you sure we need to fix this? Do we care about the bot?
> > We have a similar warning for having latest version of liburing
> > in drivers/net. I think it's useful to let the user know that
> > they are not building all the tests.
>
> the bot seems to yell every other day 'regression' in capital letters.
> I suspect people will notice sooner or later.
> If you think it's ok to just ignore it, then let's do that for now.
Alright. I think we should ignored it. I pushed the fix to a tag just
in case we need it and I'm AFK:
git://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git tags/bpf-net-xsk-move-fix
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-21 2:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 16:53 [PATCH net-next] selftests: net: don't warn when bpftool is missing Maciej Fijalkowski
2026-11-19 1:11 ` Alexei Starovoitov
2026-11-21 2:03 ` Jakub Kicinski
2026-11-21 2:06 ` Alexei Starovoitov
2026-11-21 2:15 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox