Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: David Matlack <dmatlack@google.com>
Cc: kexec@lists.infradead.org,  linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,  linux-kselftest@vger.kernel.org,
	linux-mm@kvack.org,  Alexander Graf <graf@amazon.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	 Baolin Wang <baolin.wang@linux.alibaba.com>,
	Christian Brauner <brauner@kernel.org>,
	 David Hildenbrand <david@kernel.org>,
	 Hugh Dickins <hughd@google.com>,
	 Jonathan Corbet <corbet@lwn.net>,
	 "Liam R. Howlett" <liam@infradead.org>,
	 Lorenzo Stoakes <ljs@kernel.org>,
	 Michal Hocko <mhocko@suse.com>,  Mike Rapoport <rppt@kernel.org>,
	 Pasha Tatashin <pasha.tatashin@soleen.com>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Randy Dunlap <rdunlap@infradead.org>,
	Samiullah Khawaja <skhawaja@google.com>,
	 Shuah Khan <skhan@linuxfoundation.org>,
	 Suren Baghdasaryan <surenb@google.com>,
	Vlastimil Babka <vbabka@kernel.org>
Subject: Re: [PATCH v4 14/19] selftests/liveupdate: Test which tmpfs files can be preserved
Date: Fri, 20 Nov 2026 14:29:19 +0000	[thread overview]
Message-ID: <2vxzh5hb1sqo.fsf@kernel.org> (raw)
In-Reply-To: <20261111002358.1842967-15-dmatlack@google.com> (David Matlack's message of "Wed, 11 Nov 2026 00:23:52 +0000")

On Wed, Nov 11 2026, David Matlack wrote:

> Add tests to liveupdate.c for the checks done when preserving a tmpfs
> file: A file can be preserved through a read-only fd, but not a
> write-only fd. Preserving it requires permission to write to it, except
> for the owner of an immutable file or of a file on a read-only
> superblock. Append-only files can't be preserved, and files can be
> preserved through a read-only mount. Also check that the size of a
> preserved file is frozen until the file is unpreserved.
>
> These checks don't need a kexec, so they run as part of the regular
> liveupdate selftest.
>
> Enable CONFIG_TMPFS_XATTR for FS_IOC_SETFLAGS. The test cases that use
> it are skipped without it.
>
> Signed-off-by: David Matlack <dmatlack@google.com>
> ---
>  tools/testing/selftests/liveupdate/config     |   1 +
>  .../testing/selftests/liveupdate/liveupdate.c | 303 ++++++++++++++++++
>  2 files changed, 304 insertions(+)
>
[...]
> +/*
> + * Test Case: Frozen Size of a Preserved File
> + *
> + * While a file is preserved, its size can't change and no holes can be punched
> + * into it. Writes within the file still work. Closing the session unpreserves
> + * the file, after which its size can change again.
> + */
> +TEST_F(preserve_tmpfs, frozen_size)

Nit: This test isn't really for "frozen size", it makes sure a preserved
file behaves as we expect it to. So perhaps call it "preserved_ops" and
update the comment?

> +{
> +	long page_size = getpagesize();
> +	struct stat st;
> +	char c;
> +	int fd;
> +
> +	fd = create_file("file", 0644);
> +	ASSERT_GE(fd, 0);
> +	ASSERT_EQ(ftruncate(fd, 2 * page_size), 0);
> +	ASSERT_EQ(luo_session_preserve_fd(self->session_fd, fd, 1), 0);
> +
> +	EXPECT_EQ(ftruncate(fd, page_size), -1);
> +	EXPECT_EQ(errno, EPERM);
> +	EXPECT_EQ(ftruncate(fd, 4 * page_size), -1);
> +	EXPECT_EQ(errno, EPERM);
> +	EXPECT_EQ(fallocate(fd, 0, 0, 4 * page_size), -1);
> +	EXPECT_EQ(errno, EPERM);
> +	EXPECT_EQ(fallocate(fd, FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE, 0,
> +			    page_size), -1);
> +	EXPECT_EQ(errno, EPERM);
> +	EXPECT_EQ(pwrite(fd, "x", 1, 2 * page_size), -1);
> +	EXPECT_EQ(errno, EPERM);

Nit: Is there any point in matching the exact error code? Wouldn't
checking for a failed syscall be enough?

> +
> +	/* The size didn't change, but writes within the file work. */
> +	ASSERT_EQ(fstat(fd, &st), 0);
> +	EXPECT_EQ(st.st_size, 2 * page_size);
> +	EXPECT_EQ(pwrite(fd, "x", 1, page_size), 1);
> +	EXPECT_EQ(pread(fd, &c, 1, page_size), 1);
> +	EXPECT_EQ(c, 'x');
> +
> +	ASSERT_EQ(close(self->session_fd), 0);
> +	self->session_fd = -1;
> +	EXPECT_EQ(ftruncate(fd, page_size), 0);
> +
> +	close(fd);
> +}
> +
>  TEST_HARNESS_MAIN

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2026-11-20 14:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  0:23 [PATCH v4 00/19] liveupdate: Preserve tmpfs files across Live Update David Matlack
2026-11-11  0:23 ` [PATCH v4 01/19] liveupdate: Remove the list of steps from luo_preserve_file()'s comment David Matlack
2026-11-19 18:26   ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 02/19] liveupdate: Pass user argument to file preserve and retrieve David Matlack
2026-11-11  0:23 ` [PATCH v4 03/19] selftests/liveupdate: Add tests for preserve and retrieve user argument David Matlack
2026-11-11  0:23 ` [PATCH v4 04/19] liveupdate: Allow file handlers to mark retrieve failures as retryable David Matlack
2026-11-19 18:38   ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 05/19] mm: Rename memfd_luo to shmem_luo David Matlack
2026-11-11  0:23 ` [PATCH v4 06/19] liveupdate: Don't WARN if tracking a retrieved file fails David Matlack
2026-11-20  9:58   ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 07/19] liveupdate: Add helpers to track the files that LUO manages David Matlack
2026-11-20 11:15   ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 08/19] liveupdate: Let file handlers retrieve into an existing file David Matlack
2026-11-20  9:23   ` Christian Brauner
2026-11-20 11:36     ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 09/19] mm/shmem_luo: Leave freeing the preserved state to finish() David Matlack
2026-11-20 11:55   ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 10/19] mm/shmem_luo: Don't make early retrieve failures permanent David Matlack
2026-11-20 12:02   ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 11/19] mm/shmem_luo: Require permission to preserve a file David Matlack
2026-11-20 12:18   ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 12/19] mm/shmem_luo: Retrieve tmpfs files into a file created by userspace David Matlack
2026-11-20 13:51   ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 13/19] mm/shmem_luo: Allow preserving tmpfs files David Matlack
2026-11-20 13:55   ` Pratyush Yadav
2026-11-11  0:23 ` [PATCH v4 14/19] selftests/liveupdate: Test which tmpfs files can be preserved David Matlack
2026-11-20 14:29   ` Pratyush Yadav [this message]
2026-11-11  0:23 ` [PATCH v4 15/19] selftests/liveupdate: Add a test for retrieving tmpfs files David Matlack
2026-11-11  0:23 ` [PATCH v4 16/19] selftests/liveupdate: Test memfds and LUO interactions in luo_tmpfs David Matlack
2026-11-11  0:23 ` [PATCH v4 17/19] selftests/liveupdate: Test the targets of retrieved tmpfs files David Matlack
2026-11-11  0:23 ` [PATCH v4 18/19] selftests/liveupdate: Test retrieving tmpfs files preserved read-only David Matlack
2026-11-11  0:23 ` [PATCH v4 19/19] selftests/liveupdate: Test block accounting of retrieved tmpfs files David Matlack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2vxzh5hb1sqo.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=brauner@kernel.org \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=dmatlack@google.com \
    --cc=graf@amazon.com \
    --cc=hughd@google.com \
    --cc=kexec@lists.infradead.org \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=rdunlap@infradead.org \
    --cc=rppt@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=skhawaja@google.com \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox