From: Waiman Long <longman@redhat.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: "Tejun Heo" <tj@kernel.org>, "Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <shuah@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Roman Gushchin" <guro@fb.com>, "Phil Auld" <pauld@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH v12 09/10] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst
Date: Tue, 6 Sep 2022 10:57:51 -0400 [thread overview]
Message-ID: <323f6375-0e1b-8326-2c74-b7a4db4693a1@redhat.com> (raw)
In-Reply-To: <YxRfy/SaKkJSm5jY@debian.me>
On 9/4/22 04:20, Bagas Sanjaya wrote:
> On Thu, Sep 01, 2022 at 04:57:44PM -0400, Waiman Long wrote:
>> It accepts only the following input values when written to.
>>
>> ======== ================================
>> - "root" a partition root
>> - "member" a non-root member of a partition
>> + "member" Non-root member of a partition
>> + "root" Partition root
>> + "isolated" Partition root without load balancing
>> ======== ================================
>>
>> <snipped>
>> + On read, the "cpuset.cpus.partition" file can show the following
>> + values.
>> +
>> + ====================== ==============================
>> + "member" Non-root member of a partition
>> + "root" Partition root
>> + "isolated" Partition root without load balancing
>> + "root invalid (<reason>)" Invalid partition root
>> + "isolated invalid (<reason>)" Invalid isolated partition root
>> + ====================== ==============================
>> +
> These tables above produced htmldocs warnings:
>
> Documentation/admin-guide/cgroup-v2.rst:2191: WARNING: Malformed table.
> Text in column margin in table line 4.
>
> ======== ================================
> "member" Non-root member of a partition
> "root" Partition root
> "isolated" Partition root without load balancing
> ======== ================================
> Documentation/admin-guide/cgroup-v2.rst:2229: WARNING: Malformed table.
> Text in column margin in table line 5.
>
> ====================== ==============================
> "member" Non-root member of a partition
> "root" Partition root
> "isolated" Partition root without load balancing
> "root invalid (<reason>)" Invalid partition root
> "isolated invalid (<reason>)" Invalid isolated partition root
> ====================== ==============================
>
> I have applied the fixup:
>
> ---- >8 ----
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 76b3ea9fd5c560..77b6faecf066cb 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -2185,11 +2185,11 @@ Cpuset Interface Files
>
> It accepts only the following input values when written to.
>
> - ======== ================================
> + ========== ================================
> "member" Non-root member of a partition
> "root" Partition root
> "isolated" Partition root without load balancing
> - ======== ================================
> + ========== ================================
>
> The root cgroup is always a partition root and its state
> cannot be changed. All other non-root cgroups start out as
> @@ -2222,13 +2222,13 @@ Cpuset Interface Files
> On read, the "cpuset.cpus.partition" file can show the following
> values.
>
> - ====================== ==============================
> + ============================= =====================================
> "member" Non-root member of a partition
> "root" Partition root
> "isolated" Partition root without load balancing
> "root invalid (<reason>)" Invalid partition root
> "isolated invalid (<reason>)" Invalid isolated partition root
> - ====================== ==============================
> + ============================= =====================================
>
> In the case of an invalid partition root, a descriptive string on
> why the partition is invalid is included within parentheses.
>
> Thanks.
Thanks for the fixes. Will apply that.
Cheers,
Longman
next prev parent reply other threads:[~2022-09-06 15:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 20:57 [PATCH v12 00/10] cgroup/cpuset: cpu partition code fixes & enhancements Waiman Long
2022-09-01 20:57 ` [PATCH v12 01/10] cgroup/cpuset: Enable update_tasks_cpumask() on top_cpuset Waiman Long
2022-09-01 20:57 ` [PATCH v12 02/10] cgroup/cpuset: Miscellaneous cleanups & add helper functions Waiman Long
2022-09-01 20:57 ` [PATCH v12 03/10] cgroup/cpuset: Allow no-task partition to have empty cpuset.cpus.effective Waiman Long
2022-09-01 20:57 ` [PATCH v12 04/10] cgroup/cpuset: Relax constraints to partition & cpus changes Waiman Long
2022-09-01 20:57 ` [PATCH v12 05/10] cgroup/cpuset: Add a new isolated cpus.partition type Waiman Long
2022-09-01 20:57 ` [PATCH v12 06/10] cgroup/cpuset: Show invalid partition reason string Waiman Long
2022-09-01 20:57 ` [PATCH v12 07/10] cgroup/cpuset: Relocate a code block in validate_change() Waiman Long
2022-09-01 20:57 ` [PATCH v12 08/10] cgroup/cpuset: Make partition invalid if cpumask change violates exclusivity rule Waiman Long
2022-09-01 20:57 ` [PATCH v12 09/10] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst Waiman Long
2022-09-04 2:26 ` kernel test robot
2022-09-04 8:20 ` Bagas Sanjaya
2022-09-06 14:57 ` Waiman Long [this message]
2022-09-01 20:57 ` [PATCH v12 10/10] kselftest/cgroup: Add cpuset v2 partition root state test Waiman Long
2022-09-04 20:48 ` [PATCH v12 00/10] cgroup/cpuset: cpu partition code fixes & enhancements Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=323f6375-0e1b-8326-2c74-b7a4db4693a1@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=frederic@kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=mtosatti@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox