From: wuyifan <wuyifan50@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <catalin.marinas@arm.com>, <will@kernel.org>, <shuah@kernel.org>,
<yeoreum.yun@arm.com>, <jonathan.cameron@huawei.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kselftest@vger.kernel.org>, <linuxarm@huawei.com>,
<xiaqinxin@huawei.com>, <prime.zeng@hisilicon.com>,
<wangyushan12@huawei.com>, <xuwei5@huawei.com>,
<fanghao11@huawei.com>, <wangzhou1@hisilicon.com>
Subject: Re: [PATCH 1/2] selftests/arm64: Implement cmpbr_sigill() to hwcap test
Date: Mon, 2 Mar 2026 11:50:43 +0800 [thread overview]
Message-ID: <3400c77a-8af2-4c06-8d8a-e718b6f72cfb@huawei.com> (raw)
In-Reply-To: <aaLsU2sBQh3nW9c6@sirena.co.uk>
Hi Mark,
On 2/28/2026 9:23 PM, Mark Brown wrote:
> On Fri, Feb 27, 2026 at 11:19:32AM +0800, Yifan Wu wrote:
>
>> static void cmpbr_sigill(void)
>> {
>> - /* Not implemented, too complicated and unreliable anyway */
>> + /* CBEQ x0, x0, +8 */
>> + asm volatile(".inst 0x74C00040" : : : "x0");
>> + /* UDF #0 */
>> + asm volatile("udf #0" : : : );
>> }
> I don't expect it to make a difference but it'd be nice if these were a
> single asm volatile statement, just to make it absolutely clear that no
> instrumentation or anything is supposed to go between the two.
Thanks for the review. That's a good point, I'll combine them in v2.
Regards,
Yifan Wu
next prev parent reply other threads:[~2026-03-02 3:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 3:19 [PATCH 0/2] selftests/arm64: Add cmpbr_sigill() and fix sve2p1_sigill() for hwcap test Yifan Wu
2026-02-27 3:19 ` [PATCH 1/2] selftests/arm64: Implement cmpbr_sigill() to " Yifan Wu
2026-02-28 13:23 ` Mark Brown
2026-03-02 3:50 ` wuyifan [this message]
2026-02-27 3:19 ` [PATCH 2/2] selftest/arm64: Fix sve2p1_sigill() " Yifan Wu
2026-02-28 13:39 ` Mark Brown
2026-03-02 3:40 ` wuyifan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3400c77a-8af2-4c06-8d8a-e718b6f72cfb@huawei.com \
--to=wuyifan50@huawei.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=fanghao11@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=shuah@kernel.org \
--cc=wangyushan12@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
--cc=xiaqinxin@huawei.com \
--cc=xuwei5@huawei.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox