* [PATCH net v2] selftests: forwarding: no_forwarding: Fix issue related with assigning two different vids to the same interface.
@ 2024-09-27 7:03 Kacper Ludwiński
2024-09-27 16:16 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Kacper Ludwiński @ 2024-09-27 7:03 UTC (permalink / raw)
To: davem@davemloft.net
Cc: kuba@kernel.org, vladimir.oltean@nxp.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, petrm@nvidia.com,
horms@kernel.org, edumazet@google.com, shuah@kernel.org
Fix typo.
Currently, the second bridge command overwrites the first one.
Fix this by adding this VID to the interface behind $swp2.
Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
Signed-off-by: Kacper Ludwinski <kacper@ludwinski.dev>
---
tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh
index 9e677aa64a06..694ece9ba3a7 100755
--- a/tools/testing/selftests/net/forwarding/no_forwarding.sh
+++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh
@@ -202,7 +202,7 @@ one_bridge_two_pvids()
ip link set $swp2 master br0
bridge vlan add dev $swp1 vid 1 pvid untagged
- bridge vlan add dev $swp1 vid 2 pvid untagged
+ bridge vlan add dev $swp2 vid 2 pvid untagged
run_test "Switch ports in VLAN-aware bridge with different PVIDs"
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net v2] selftests: forwarding: no_forwarding: Fix issue related with assigning two different vids to the same interface.
2024-09-27 7:03 [PATCH net v2] selftests: forwarding: no_forwarding: Fix issue related with assigning two different vids to the same interface Kacper Ludwiński
@ 2024-09-27 16:16 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2024-09-27 16:16 UTC (permalink / raw)
To: Kacper Ludwiński, davem@davemloft.net
Cc: kuba@kernel.org, vladimir.oltean@nxp.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, petrm@nvidia.com,
horms@kernel.org, edumazet@google.com, shuah@kernel.org,
Shuah Khan
On 9/27/24 01:03, Kacper Ludwiński wrote:
> Fix typo.
Remove the above line. It gives the impression that this is
a minor spelling fix when it is not. It is fixing a problem
that prevents the test from running correctly.
> Currently, the second bridge command overwrites the first one.
> Fix this by adding this VID to the interface behind $swp2.
>
> Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
> Signed-off-by: Kacper Ludwinski <kacper@ludwinski.dev>
> ---
> tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh
> index 9e677aa64a06..694ece9ba3a7 100755
> --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh
> +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh
> @@ -202,7 +202,7 @@ one_bridge_two_pvids()
> ip link set $swp2 master br0
>
> bridge vlan add dev $swp1 vid 1 pvid untagged
> - bridge vlan add dev $swp1 vid 2 pvid untagged
> + bridge vlan add dev $swp2 vid 2 pvid untagged
>
> run_test "Switch ports in VLAN-aware bridge with different PVIDs"
>
> --
> 2.43.0
>
With the above change:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-27 16:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-27 7:03 [PATCH net v2] selftests: forwarding: no_forwarding: Fix issue related with assigning two different vids to the same interface Kacper Ludwiński
2024-09-27 16:16 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox