From: John Hubbard <jhubbard@nvidia.com>
To: Kees Cook <kees@kernel.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Shuah Khan <shuah@kernel.org>, <davidgow@google.com>,
"open list : KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
<kunit-dev@googlegroups.com>,
"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: Converting kselftest test modules to kunit
Date: Wed, 17 Jul 2024 14:11:33 -0700 [thread overview]
Message-ID: <81c79e52-4e77-45c8-bc42-00b5d096d6d9@nvidia.com> (raw)
In-Reply-To: <202407161124.8DF2E794AF@keescook>
On 7/16/24 11:26 AM, Kees Cook wrote:
> On Tue, Jul 16, 2024 at 11:04:06AM -0700, John Hubbard wrote:
>> This is a classic case of testing a kernel API via ioctl into the
>> kernel, so I think it meets your criteria for moving to KUnit.
>> Having said that, I must now go try out KUnit in a bit more depth
>> before I'm sure that this will work out. But it should.
>
> I've found the docs really helpful:
> https://docs.kernel.org/dev-tools/kunit/
>
> Searching for *_kunit.c will also give a lot of examples. And the kunit
> folks are really responsive to questions, helping guide finding solutions
> to novel testing needs, etc. :)
>
OK, yes very helpful. I guess I've got some unique biases, because I
found it extremely odd to put so much emphasis on the arch=UM, as
opposed to loading a kunit kernel module on baremetal and running
tests there. I mean, yes, VMs or user mode Linux have their place,
but baremetal testing is really important (and in many cases, the
only way).
Anyway, this confirms for me that kunit should work perfectly for
converting mm/gup_test.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2024-07-17 21:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 10:09 Converting kselftest test modules to kunit Muhammad Usama Anjum
2024-07-15 16:40 ` Kees Cook
2024-07-16 8:11 ` Muhammad Usama Anjum
2024-07-16 17:59 ` Kees Cook
2024-07-16 18:04 ` John Hubbard
2024-07-16 18:26 ` Kees Cook
2024-07-17 21:11 ` John Hubbard [this message]
2024-07-17 10:55 ` Muhammad Usama Anjum
2024-07-16 7:33 ` David Gow
2024-07-17 10:47 ` Muhammad Usama Anjum
2024-07-17 21:44 ` John Hubbard
2024-07-26 19:35 ` Shuah Khan
2024-07-29 7:55 ` Muhammad Usama Anjum
2024-07-30 22:55 ` Shuah Khan
2024-07-30 5:23 ` David Gow
2024-07-30 22:53 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81c79e52-4e77-45c8-bc42-00b5d096d6d9@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=davidgow@google.com \
--cc=kees@kernel.org \
--cc=kernel@collabora.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox