Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: mpe at ellerman.id.au (Michael Ellerman)
Subject: [PATCH v4 3/3] kselftest: Extend vDSO selftest to clock_getres
Date: Tue, 28 May 2019 16:19:21 +1000	[thread overview]
Message-ID: <87lfyrp0d2.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20190523112116.19233-4-vincenzo.frascino@arm.com>

Vincenzo Frascino <vincenzo.frascino at arm.com> writes:

> The current version of the multiarch vDSO selftest verifies only
> gettimeofday.
>
> Extend the vDSO selftest to clock_getres, to verify that the
> syscall and the vDSO library function return the same information.
>
> The extension has been used to verify the hrtimer_resoltion fix.

This is passing for me even without patch 1 applied, shouldn't it fail
without the fix? What am I missing?

# uname -r
5.2.0-rc2-gcc-8.2.0

# ./vdso_clock_getres
clock_id: CLOCK_REALTIME [PASS]
clock_id: CLOCK_BOOTTIME [PASS]
clock_id: CLOCK_TAI [PASS]
clock_id: CLOCK_REALTIME_COARSE [PASS]
clock_id: CLOCK_MONOTONIC [PASS]
clock_id: CLOCK_MONOTONIC_RAW [PASS]
clock_id: CLOCK_MONOTONIC_COARSE [PASS]

cheers

> Cc: Shuah Khan <shuah at kernel.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino at arm.com>
> ---
>
> Note: This patch is independent from the others in this series, hence it
> can be merged singularly by the kselftest maintainers.
>
>  tools/testing/selftests/vDSO/Makefile         |   2 +
>  .../selftests/vDSO/vdso_clock_getres.c        | 124 ++++++++++++++++++
>  2 files changed, 126 insertions(+)
>  create mode 100644 tools/testing/selftests/vDSO/vdso_clock_getres.c

WARNING: multiple messages have this Message-ID (diff)
From: mpe@ellerman.id.au (Michael Ellerman)
Subject: [PATCH v4 3/3] kselftest: Extend vDSO selftest to clock_getres
Date: Tue, 28 May 2019 16:19:21 +1000	[thread overview]
Message-ID: <87lfyrp0d2.fsf@concordia.ellerman.id.au> (raw)
Message-ID: <20190528061921.PLXX4E-6HH0bbgoXs8U_QL9iRl2vb3yhwqpHRp-YsWU@z> (raw)
In-Reply-To: <20190523112116.19233-4-vincenzo.frascino@arm.com>

Vincenzo Frascino <vincenzo.frascino at arm.com> writes:

> The current version of the multiarch vDSO selftest verifies only
> gettimeofday.
>
> Extend the vDSO selftest to clock_getres, to verify that the
> syscall and the vDSO library function return the same information.
>
> The extension has been used to verify the hrtimer_resoltion fix.

This is passing for me even without patch 1 applied, shouldn't it fail
without the fix? What am I missing?

# uname -r
5.2.0-rc2-gcc-8.2.0

# ./vdso_clock_getres
clock_id: CLOCK_REALTIME [PASS]
clock_id: CLOCK_BOOTTIME [PASS]
clock_id: CLOCK_TAI [PASS]
clock_id: CLOCK_REALTIME_COARSE [PASS]
clock_id: CLOCK_MONOTONIC [PASS]
clock_id: CLOCK_MONOTONIC_RAW [PASS]
clock_id: CLOCK_MONOTONIC_COARSE [PASS]

cheers

> Cc: Shuah Khan <shuah at kernel.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino at arm.com>
> ---
>
> Note: This patch is independent from the others in this series, hence it
> can be merged singularly by the kselftest maintainers.
>
>  tools/testing/selftests/vDSO/Makefile         |   2 +
>  .../selftests/vDSO/vdso_clock_getres.c        | 124 ++++++++++++++++++
>  2 files changed, 126 insertions(+)
>  create mode 100644 tools/testing/selftests/vDSO/vdso_clock_getres.c

  parent reply	other threads:[~2019-05-28  6:19 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 11:21 [PATCH v4 0/3] Fix vDSO clock_getres() vincenzo.frascino
2019-05-23 11:21 ` Vincenzo Frascino
2019-05-23 11:21 ` [PATCH v4 1/3] powerpc: " vincenzo.frascino
2019-05-23 11:21   ` Vincenzo Frascino
2019-05-23 11:21 ` [PATCH v4 2/3] s390: " vincenzo.frascino
2019-05-23 11:21   ` Vincenzo Frascino
2019-05-23 11:21 ` [PATCH v4 3/3] kselftest: Extend vDSO selftest to clock_getres vincenzo.frascino
2019-05-23 11:21   ` Vincenzo Frascino
2019-05-28  6:19   ` mpe [this message]
2019-05-28  6:19     ` Michael Ellerman
2019-05-28 11:57     ` vincenzo.frascino
2019-05-28 11:57       ` Vincenzo Frascino
2019-05-28 17:01       ` christophe.leroy
2019-05-28 17:01         ` Christophe Leroy
2019-05-28 17:05         ` vincenzo.frascino
2019-05-28 17:05           ` Vincenzo Frascino
2019-06-04 13:16       ` christophe.leroy
2019-06-04 13:16         ` Christophe Leroy
2019-06-04 13:32         ` vincenzo.frascino
2019-06-04 13:32           ` Vincenzo Frascino
2019-06-04 13:39           ` christophe.leroy
2019-06-04 13:39             ` Christophe Leroy
2019-06-04 13:43             ` vincenzo.frascino
2019-06-04 13:43               ` Vincenzo Frascino
2019-06-04 13:52               ` christophe.leroy
2019-06-04 13:52                 ` Christophe Leroy
2019-06-04 14:21                 ` vincenzo.frascino
2019-06-04 14:21                   ` Vincenzo Frascino
2019-06-13 15:22       ` Vincenzo Frascino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfyrp0d2.fsf@concordia.ellerman.id.au \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox