From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Shuah Khan <shuah@kernel.org>,
alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa - mixer-test: Don't fail tests if we can't restore default
Date: Wed, 08 Mar 2023 06:34:57 +0100 [thread overview]
Message-ID: <87mt4niz5q.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230224-alsa-mixer-test-restore-invalid-v1-1-454f0f1f2c4b@kernel.org>
On Mon, 06 Mar 2023 15:20:03 +0100,
Mark Brown wrote:
>
> If a control has an invalid default value then we might fail to set it
> when restoring the default value after our write tests, for example due to
> correctly implemented range checks in put() operations. Currently this
> causes us to report the tests we were running as failed even when the
> operation we were trying to test is successful, making it look like there
> are problems where none really exist. Stop doing this, only reporting any
> issues during the actual test.
>
> We already have validation for the initial readback being in spec and for
> writing the default value back so failed tests will be reported for these
> controls, and we log an error on the operation that failed when we write so
> there will be a diagnostic warning the user that there is a problem.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2023-03-08 5:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 14:20 [PATCH] kselftest/alsa - mixer-test: Don't fail tests if we can't restore default Mark Brown
2023-03-08 5:34 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt4niz5q.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox