From: Takashi Iwai <tiwai@suse.de>
To: Alexander Heinrich <hallo@alexanderheinrich.de>
Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] kselftest/alsa: Fix -Wformat compiler warnings
Date: Fri, 24 Mar 2023 10:44:29 +0100 [thread overview]
Message-ID: <87r0te5vr6.wl-tiwai@suse.de> (raw)
In-Reply-To: <87sfdu5vsl.wl-tiwai@suse.de>
On Fri, 24 Mar 2023 10:43:38 +0100,
Takashi Iwai wrote:
>
> On Fri, 24 Mar 2023 10:28:06 +0100,
> Alexander Heinrich wrote:
> >
> > I noticed some -Wformat compiler warnings in pcm-test.c while building
> > kselftest, fix them by using the same types for format specifier and arguments.
> >
> > Signed-off-by: Alexander Heinrich <hallo@alexanderheinrich.de>
>
> Those variables (rates, channels, etc) should be rather int instead of
> long, as these are not 64bit parameters on 32bit archs.
> On top of that, the whole '%l' prefix and cast should be dropped.
>
> The only concern is the string to int conversion, and this should be
> checked carefully, but other than that, it must be straightforward.
>
> Care to work on that way?
... and the code has been already changed meanwhile. Please work on
for-next branch of my sound.git tree.
thanks,
Takashi
prev parent reply other threads:[~2023-03-24 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 9:28 [PATCH] kselftest/alsa: Fix -Wformat compiler warnings Alexander Heinrich
2023-03-24 9:43 ` Takashi Iwai
2023-03-24 9:44 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0te5vr6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=hallo@alexanderheinrich.de \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox