From: Jakub Sitnicki <jakub@cloudflare.com>
To: Geliang Tang <geliang@kernel.org>,
John Fastabend <john.fastabend@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>,
Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
Shuah Khan <shuah@kernel.org>,
Geliang Tang <tanggeliang@kylinos.cn>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next 3/8] selftests/bpf: Use bpf_link attachments in test_sockmap
Date: Fri, 31 May 2024 13:13:39 +0200 [thread overview]
Message-ID: <87wmnaw7x8.fsf@cloudflare.com> (raw)
In-Reply-To: <66590f821d120_e5072085a@john.notmuch> (John Fastabend's message of "Thu, 30 May 2024 16:45:06 -0700")
On Thu, May 30, 2024 at 04:45 PM -07, John Fastabend wrote:
> Geliang Tang wrote:
>> On Mon, 2024-05-27 at 21:36 +0200, Jakub Sitnicki wrote:
>> > On Mon, May 27, 2024 at 10:12 AM -07, John Fastabend wrote:
>> > > Geliang Tang wrote:
[...]
>> > > The one advantage of test_sockmap is we can have it run for longer
>> > > runs by pushing different options through so might be worth keeping
>> > > just for that.
>> > >
>> > > If you really want links here I'm OK with that I guess just asking.
>> >
>> > It was me who suggested the switch to bpf_link in reaction to a
>> > series
>> > of cleanups to prog_type and prog_attach_type submitted by Geliang.
>>
>> Yes, patches 3-5 address Jakub's suggestion: switching attachments to
>> bpf_link.
>
> OK. Lets just take them the series lgtm. Jakub any other comments?
Gave it a run - all looks well. Thanks for the patches.
Geliang, is there some MPTCP+sockmap use-case you're working towards?
next prev parent reply other threads:[~2024-05-31 11:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 6:49 [PATCH bpf-next 0/8] fixes for test_sockmap Geliang Tang
2024-05-23 6:49 ` [PATCH bpf-next 1/8] selftests/bpf: Fix tx_prog_fd values in test_sockmap Geliang Tang
2024-05-27 17:02 ` John Fastabend
2024-05-23 6:49 ` [PATCH bpf-next 2/8] selftests/bpf: Drop duplicate definition of i " Geliang Tang
2024-05-27 17:03 ` John Fastabend
2024-05-23 6:49 ` [PATCH bpf-next 3/8] selftests/bpf: Use bpf_link attachments " Geliang Tang
2024-05-27 17:12 ` John Fastabend
2024-05-27 19:36 ` Jakub Sitnicki
2024-05-28 4:12 ` Geliang Tang
2024-05-30 23:45 ` John Fastabend
2024-05-31 11:13 ` Jakub Sitnicki [this message]
2024-05-31 14:35 ` Geliang Tang
2024-05-23 6:50 ` [PATCH bpf-next 4/8] selftests/bpf: Replace tx_prog_fd with tx_prog " Geliang Tang
2024-05-23 6:50 ` [PATCH bpf-next 5/8] selftests/bpf: Drop prog_fd array " Geliang Tang
2024-05-23 6:50 ` [PATCH bpf-next 6/8] selftests/bpf: Fix size of map_fd " Geliang Tang
2024-05-27 17:06 ` John Fastabend
2024-05-23 6:50 ` [PATCH bpf-next 7/8] selftests/bpf: Check length of recv " Geliang Tang
2024-05-27 17:06 ` John Fastabend
2024-05-23 6:50 ` [PATCH bpf-next 8/8] selftests/bpf: Drop duplicate bpf_map_lookup_elem " Geliang Tang
2024-05-27 17:06 ` John Fastabend
2024-05-31 11:06 ` [PATCH bpf-next 0/8] fixes for test_sockmap Jakub Sitnicki
2024-06-03 17:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmnaw7x8.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=geliang@kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox