Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Meng Li <li.meng@amd.com>, Huang Rui <ray.huang@amd.com>,
	linux-kselftest@vger.kernel.org
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Nathan Fontenot <nathan.fontenot@amd.com>,
	Deepak Sharma <deepak.sharma@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Shimmer Huang <shimmer.huang@amd.com>,
	Perry Yuan <Perry.Yuan@amd.com>,
	Xiaojian Du <Xiaojian.Du@amd.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Borislav Petkov <bp@alien8.de>,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH V5 0/5] Add tbench/gitsource new test cases for amd-pstate-ut
Date: Mon, 31 Oct 2022 04:04:14 -0600	[thread overview]
Message-ID: <899fc0ab-18d1-a563-10ea-b91623422570@linuxfoundation.org> (raw)
In-Reply-To: <20221031084924.1742169-1-li.meng@amd.com>

On 10/31/22 02:49, Meng Li wrote:
> Hi all:
> 
> First, rename amd-pstate-ut.sh to basic.sh as a basic test, mainly for
> AMD P-State kernel drivers. The purpose of this modification is to
> facilitate the subsequent addition of gitsource, tbench and other tests.
> 
> Second, split basic.sh into run.sh and basic.sh.
> The modification makes basic.sh more pure, just for test basic kernel
> functions. The file of run.sh mainly contains functions such as test
> entry, parameter check, prerequisite and log clearing etc.
> 
> Third, add tbench.sh trigger the tbench testing and monitor the cpu.
> 
> Fourth, add gitsource.sh trigger the gitsource testing and monitor the cpu
> information.
> 
> Finally, modify rst document to introduce test steps and results etc.
> 

> 
> Changes from V4->V5:
> - selftests: amd-pstate:
> - - rename amd-pstate-ut.sh to basic.sh.
> - - split basic.sh into run.sh and basic.sh.
> - - modify tbench.sh to prompt to install tbench.
> - - modify commit messages and description informations of shell files.
> - Documentation: amd-pstate:
> - - correct spell errors.
> 

v5 series looks good. Please cleanup checkpatch errors in a couple of files.
Not too concerned about long line warnings as these seem like "echo"
statements with output text.

thanks,
-- Shuah

  parent reply	other threads:[~2022-10-31 10:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31  8:49 [PATCH V5 0/5] Add tbench/gitsource new test cases for amd-pstate-ut Meng Li
2022-10-31  8:49 ` [PATCH V5 1/5] selftests: amd-pstate: Rename amd-pstate-ut.sh to basic.sh Meng Li
2022-10-31  8:49 ` [PATCH V5 2/5] selftests: amd-pstate: Split basic.sh into run.sh and basic.sh Meng Li
2022-10-31  8:49 ` [PATCH V5 3/5] selftests: amd-pstate: Trigger tbench benchmark and test cpus Meng Li
2022-10-31  8:49 ` [PATCH V5 4/5] selftests: amd-pstate: Trigger gitsource " Meng Li
2022-10-31  8:49 ` [PATCH V5 5/5] Documentation: amd-pstate: Add tbench and gitsource test introduction Meng Li
2022-10-31 10:04 ` Shuah Khan [this message]
2022-11-01  9:26   ` [PATCH V5 0/5] Add tbench/gitsource new test cases for amd-pstate-ut Shuah Khan
2022-11-02  4:27     ` Meng, Li (Jassmine)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=899fc0ab-18d1-a563-10ea-b91623422570@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=Perry.Yuan@amd.com \
    --cc=Xiaojian.Du@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=bp@alien8.de \
    --cc=deepak.sharma@amd.com \
    --cc=li.meng@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=nathan.fontenot@amd.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ray.huang@amd.com \
    --cc=shimmer.huang@amd.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox