From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: linux@treblig.org, davidgow@google.com
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] list: test: remove unused struct 'klist_test_struct'
Date: Fri, 31 May 2024 23:19:57 +0500 [thread overview]
Message-ID: <89e07c93-a54d-4cc2-8ee1-664389ffcdd7@collabora.com> (raw)
In-Reply-To: <20240531151801.128792-1-linux@treblig.org>
On 5/31/24 8:18 PM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'klist_test_struct' has been unused since the original
> commit 57b4f760f94d ("list: test: Test the klist structure").
Probably a fixes by tag would be needed here.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> lib/list-test.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/lib/list-test.c b/lib/list-test.c
> index 0cc27de9cec8..383ee0ad582e 100644
> --- a/lib/list-test.c
> +++ b/lib/list-test.c
> @@ -1201,12 +1201,6 @@ static struct kunit_suite hlist_test_module = {
> };
>
>
> -struct klist_test_struct {
> - int data;
> - struct klist klist;
> - struct klist_node klist_node;
> -};
> -
> static int node_count;
> static struct klist_node *last_node;
>
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2024-05-31 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 15:18 [PATCH] list: test: remove unused struct 'klist_test_struct' linux
2024-05-31 18:19 ` Muhammad Usama Anjum [this message]
2024-05-31 18:58 ` Dr. David Alan Gilbert
2024-05-31 19:13 ` Shuah Khan
2024-06-01 2:07 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89e07c93-a54d-4cc2-8ee1-664389ffcdd7@collabora.com \
--to=usama.anjum@collabora.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@treblig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox