From: Shuah Khan <skhan@linuxfoundation.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>,
Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: davidgow@google.com, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] list: test: remove unused struct 'klist_test_struct'
Date: Fri, 31 May 2024 13:13:27 -0600 [thread overview]
Message-ID: <f9091516-37ff-43d1-b515-ae8eb3f80e80@linuxfoundation.org> (raw)
In-Reply-To: <Zlod5TMzmXinDu2X@gallifrey>
On 5/31/24 12:58, Dr. David Alan Gilbert wrote:
> * Muhammad Usama Anjum (usama.anjum@collabora.com) wrote:
>> On 5/31/24 8:18 PM, linux@treblig.org wrote:
>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>
>>> 'klist_test_struct' has been unused since the original
>>> commit 57b4f760f94d ("list: test: Test the klist structure").
>> Probably a fixes by tag would be needed here.
>
> I'm generally avoiding fixes tags in this set of changes, since
> a) They have no behavioural change at all.
> b) Downstream and stable kernel people use fixes tags to indicate
> stuff they should pick up if they have the original, and there's
> no need for them to do that with this cleanup.
>
> Dave
+1 on using careful use of Fixes tag only on real fixes for the
reasons mentioned above.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-05-31 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 15:18 [PATCH] list: test: remove unused struct 'klist_test_struct' linux
2024-05-31 18:19 ` Muhammad Usama Anjum
2024-05-31 18:58 ` Dr. David Alan Gilbert
2024-05-31 19:13 ` Shuah Khan [this message]
2024-06-01 2:07 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9091516-37ff-43d1-b515-ae8eb3f80e80@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@treblig.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox