* [PATCH] selftests/binderfs: Improve message to provide more info
@ 2022-04-23 5:44 Karthik Alapati
2022-04-25 9:49 ` Christian Brauner
0 siblings, 1 reply; 3+ messages in thread
From: Karthik Alapati @ 2022-04-23 5:44 UTC (permalink / raw)
To: Shuah Khan, Greg Kroah-Hartman, Christian Brauner, Carlos Llamas
Cc: linux-kselftest, linux-kernel
Currently the binderfs test says what failure it encountered
without saying why it may occurred when it fails to mount
binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the
running kernel.
Signed-off-by: Karthik Alapati <mail@karthek.com>
---
tools/testing/selftests/filesystems/binderfs/binderfs_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
index 0315955ff0f4..bc1c407651fc 100644
--- a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
+++ b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c
@@ -412,7 +412,8 @@ TEST(binderfs_stress)
ret = mount(NULL, binderfs_mntpt, "binder", 0, 0);
ASSERT_EQ(ret, 0) {
- TH_LOG("%s - Failed to mount binderfs", strerror(errno));
+ TH_LOG("%s - Failed to mount binderfs, check if CONFIG_ANDROID_BINDERFS is enabled in the running kernel",
+ strerror(errno));
}
for (int i = 0; i < ARRAY_SIZE(fds); i++) {
--
2.35.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/binderfs: Improve message to provide more info
2022-04-23 5:44 [PATCH] selftests/binderfs: Improve message to provide more info Karthik Alapati
@ 2022-04-25 9:49 ` Christian Brauner
2022-04-25 15:47 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Christian Brauner @ 2022-04-25 9:49 UTC (permalink / raw)
To: Karthik Alapati
Cc: Shuah Khan, Greg Kroah-Hartman, Carlos Llamas, linux-kselftest,
linux-kernel
On Sat, Apr 23, 2022 at 11:14:34AM +0530, Karthik Alapati wrote:
> Currently the binderfs test says what failure it encountered
> without saying why it may occurred when it fails to mount
> binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the
> running kernel.
>
> Signed-off-by: Karthik Alapati <mail@karthek.com>
> ---
Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/binderfs: Improve message to provide more info
2022-04-25 9:49 ` Christian Brauner
@ 2022-04-25 15:47 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2022-04-25 15:47 UTC (permalink / raw)
To: Christian Brauner, Karthik Alapati
Cc: Greg Kroah-Hartman, Carlos Llamas, linux-kselftest, linux-kernel,
Shuah Khan
On 4/25/22 3:49 AM, Christian Brauner wrote:
> On Sat, Apr 23, 2022 at 11:14:34AM +0530, Karthik Alapati wrote:
>> Currently the binderfs test says what failure it encountered
>> without saying why it may occurred when it fails to mount
>> binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the
>> running kernel.
>>
>> Signed-off-by: Karthik Alapati <mail@karthek.com>
>> ---
>
> Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
>
Thank you both - I will apply this for next to be included in
Linux 5.19-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-25 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-23 5:44 [PATCH] selftests/binderfs: Improve message to provide more info Karthik Alapati
2022-04-25 9:49 ` Christian Brauner
2022-04-25 15:47 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox