* [PATCH bpf-next] selftests/bpf: Enable INET_XFRM_TUNNEL in config
@ 2024-05-16 1:41 Geliang Tang
2024-05-24 16:27 ` Daniel Borkmann
0 siblings, 1 reply; 4+ messages in thread
From: Geliang Tang @ 2024-05-16 1:41 UTC (permalink / raw)
To: Andrii Nakryiko, Eduard Zingerman, Mykola Lysenko,
Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev,
Hao Luo, Jiri Olsa, Shuah Khan
Cc: Geliang Tang, bpf, linux-kselftest
From: Geliang Tang <tanggeliang@kylinos.cn>
The kconfigs CONFIG_INET_XFRM_TUNNEL and CONFIG_INET6_XFRM_TUNNEL are
needed by test_tunnel tests. This patch enables them together with the
dependent kconfigs CONFIG_INET_IPCOMP and CONFIG_INET6_IPCOMP.
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
tools/testing/selftests/bpf/config | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
index eeabd798bc3a..8aa56e6bdac1 100644
--- a/tools/testing/selftests/bpf/config
+++ b/tools/testing/selftests/bpf/config
@@ -95,3 +95,7 @@ CONFIG_XDP_SOCKETS=y
CONFIG_XFRM_INTERFACE=y
CONFIG_TCP_CONG_DCTCP=y
CONFIG_TCP_CONG_BBR=y
+CONFIG_INET_IPCOMP=y
+CONFIG_INET_XFRM_TUNNEL=y
+CONFIG_INET6_IPCOMP=y
+CONFIG_INET6_XFRM_TUNNEL=y
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: Enable INET_XFRM_TUNNEL in config
2024-05-16 1:41 [PATCH bpf-next] selftests/bpf: Enable INET_XFRM_TUNNEL in config Geliang Tang
@ 2024-05-24 16:27 ` Daniel Borkmann
2024-05-29 0:01 ` Ilya Leoshkevich
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2024-05-24 16:27 UTC (permalink / raw)
To: Geliang Tang, Andrii Nakryiko, Eduard Zingerman, Mykola Lysenko,
Alexei Starovoitov, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
Shuah Khan
Cc: Geliang Tang, bpf, linux-kselftest, Ilya Leoshkevich
On 5/16/24 3:41 AM, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> The kconfigs CONFIG_INET_XFRM_TUNNEL and CONFIG_INET6_XFRM_TUNNEL are
> needed by test_tunnel tests. This patch enables them together with the
> dependent kconfigs CONFIG_INET_IPCOMP and CONFIG_INET6_IPCOMP.
>
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> ---
> tools/testing/selftests/bpf/config | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
> index eeabd798bc3a..8aa56e6bdac1 100644
> --- a/tools/testing/selftests/bpf/config
> +++ b/tools/testing/selftests/bpf/config
> @@ -95,3 +95,7 @@ CONFIG_XDP_SOCKETS=y
> CONFIG_XFRM_INTERFACE=y
> CONFIG_TCP_CONG_DCTCP=y
> CONFIG_TCP_CONG_BBR=y
> +CONFIG_INET_IPCOMP=y
> +CONFIG_INET_XFRM_TUNNEL=y
> +CONFIG_INET6_IPCOMP=y
> +CONFIG_INET6_XFRM_TUNNEL=y
>
[ +Ilya ]
Looks like this triggers a boot hang on s390x :
https://github.com/kernel-patches/bpf/actions/runs/9215175853/job/25353574288
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: Enable INET_XFRM_TUNNEL in config
2024-05-24 16:27 ` Daniel Borkmann
@ 2024-05-29 0:01 ` Ilya Leoshkevich
2024-06-11 2:12 ` Geliang Tang
0 siblings, 1 reply; 4+ messages in thread
From: Ilya Leoshkevich @ 2024-05-29 0:01 UTC (permalink / raw)
To: Daniel Borkmann, Geliang Tang, Andrii Nakryiko, Eduard Zingerman,
Mykola Lysenko, Alexei Starovoitov, Martin KaFai Lau, Song Liu,
Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev,
Hao Luo, Jiri Olsa, Shuah Khan
Cc: Geliang Tang, bpf, linux-kselftest
On Fri, 2024-05-24 at 18:27 +0200, Daniel Borkmann wrote:
> On 5/16/24 3:41 AM, Geliang Tang wrote:
> > From: Geliang Tang <tanggeliang@kylinos.cn>
> >
> > The kconfigs CONFIG_INET_XFRM_TUNNEL and CONFIG_INET6_XFRM_TUNNEL
> > are
> > needed by test_tunnel tests. This patch enables them together with
> > the
> > dependent kconfigs CONFIG_INET_IPCOMP and CONFIG_INET6_IPCOMP.
> >
> > Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> > ---
> > tools/testing/selftests/bpf/config | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/testing/selftests/bpf/config
> > b/tools/testing/selftests/bpf/config
> > index eeabd798bc3a..8aa56e6bdac1 100644
> > --- a/tools/testing/selftests/bpf/config
> > +++ b/tools/testing/selftests/bpf/config
> > @@ -95,3 +95,7 @@ CONFIG_XDP_SOCKETS=y
> > CONFIG_XFRM_INTERFACE=y
> > CONFIG_TCP_CONG_DCTCP=y
> > CONFIG_TCP_CONG_BBR=y
> > +CONFIG_INET_IPCOMP=y
> > +CONFIG_INET_XFRM_TUNNEL=y
> > +CONFIG_INET6_IPCOMP=y
> > +CONFIG_INET6_XFRM_TUNNEL=y
> >
>
> [ +Ilya ]
>
> Looks like this triggers a boot hang on s390x :
>
> https://github.com/kernel-patches/bpf/actions/runs/9215175853/job/25353574288
Hi,
I could not reproduce this neither with vmtest nor with my own build,
and it doesn't look related.
I'm not exactly sure what could cause d_alloc_parallel() to hang, but
apparently the CI is using a different vmtest script, which uses 9p to
mount root - perhaps there is a deadlock in 9p?
Can someone retrigger the build to see if the issue persists?
Best regards,
Ilya
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: Enable INET_XFRM_TUNNEL in config
2024-05-29 0:01 ` Ilya Leoshkevich
@ 2024-06-11 2:12 ` Geliang Tang
0 siblings, 0 replies; 4+ messages in thread
From: Geliang Tang @ 2024-06-11 2:12 UTC (permalink / raw)
To: Daniel Borkmann, Ilya Leoshkevich
Cc: Andrii Nakryiko, Eduard Zingerman, Mykola Lysenko,
Alexei Starovoitov, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
Shuah Khan, bpf, linux-kselftest
On Wed, May 29, 2024 at 02:01:06AM +0200, Ilya Leoshkevich wrote:
> On Fri, 2024-05-24 at 18:27 +0200, Daniel Borkmann wrote:
> > On 5/16/24 3:41 AM, Geliang Tang wrote:
> > > From: Geliang Tang <tanggeliang@kylinos.cn>
> > >
> > > The kconfigs CONFIG_INET_XFRM_TUNNEL and CONFIG_INET6_XFRM_TUNNEL
> > > are
> > > needed by test_tunnel tests. This patch enables them together with
> > > the
> > > dependent kconfigs CONFIG_INET_IPCOMP and CONFIG_INET6_IPCOMP.
> > >
> > > Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> > > ---
> > > tools/testing/selftests/bpf/config | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/tools/testing/selftests/bpf/config
> > > b/tools/testing/selftests/bpf/config
> > > index eeabd798bc3a..8aa56e6bdac1 100644
> > > --- a/tools/testing/selftests/bpf/config
> > > +++ b/tools/testing/selftests/bpf/config
> > > @@ -95,3 +95,7 @@ CONFIG_XDP_SOCKETS=y
> > > CONFIG_XFRM_INTERFACE=y
> > > CONFIG_TCP_CONG_DCTCP=y
> > > CONFIG_TCP_CONG_BBR=y
> > > +CONFIG_INET_IPCOMP=y
> > > +CONFIG_INET_XFRM_TUNNEL=y
> > > +CONFIG_INET6_IPCOMP=y
> > > +CONFIG_INET6_XFRM_TUNNEL=y
> > >
> >
> > [ +Ilya ]
> >
> > Looks like this triggers a boot hang on s390x :
> >
> > https://github.com/kernel-patches/bpf/actions/runs/9215175853/job/25353574288
>
> Hi,
>
> I could not reproduce this neither with vmtest nor with my own build,
> and it doesn't look related.
>
> I'm not exactly sure what could cause d_alloc_parallel() to hang, but
> apparently the CI is using a different vmtest script, which uses 9p to
> mount root - perhaps there is a deadlock in 9p?
>
> Can someone retrigger the build to see if the issue persists?
Hi Daniel, Ilya,
I'll resend this patch together with another fix for test_tunnel soon. At
that time, CI can be triggered again.
I changed this patch status as "Superseded" on patchwork.
Thanks,
-Geliang
>
> Best regards,
> Ilya
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-11 2:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 1:41 [PATCH bpf-next] selftests/bpf: Enable INET_XFRM_TUNNEL in config Geliang Tang
2024-05-24 16:27 ` Daniel Borkmann
2024-05-29 0:01 ` Ilya Leoshkevich
2024-06-11 2:12 ` Geliang Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox