Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shivam Chaudhary <cvam0000@gmail.com>
To: Shuah Khan <skhan@linuxfoundation.org>, shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] selftests: tmpfs: Add Test-skip if not run as root
Date: Fri, 3 Jan 2025 22:06:46 +0530	[thread overview]
Message-ID: <a5bf80c4-0062-4f3d-94e2-a40c1cac2934@gmail.com> (raw)
In-Reply-To: <e6d8cb36-089b-41cc-8ab7-90338bcda8de@linuxfoundation.org>


On 03/01/25 3:24 AM, Shuah Khan wrote:
> On 1/2/25 03:04, Shivam Chaudhary wrote:
>> Add 'ksft_exit_skip()', if  not run as root, with an appropriate
>> Warning.
>>
>> Add 'ksft_print_header()' and 'ksft_set_plan()' to structure test
>> outputs more effectively.
>>
>> Test logs:
>>
>> Before Change:
>> - Without root
>>   error: unshare, errno 1
>>
>> - With root
>>   No, output
>>
>> After change:
>>
>> - Without root
>> TAP version 13
>> 1..1
>> ok 2 # SKIP This test needs root to run!
>> Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
>>
>> - With root
>> TAP version 13
>> 1..1
>
> How are you running this test to see the before ad after
> results?

I'm doing the unit test, meaning, I'm building the test separatley and 
running it

to ensure the the code works as expected.

thanks

--Shivam


  reply	other threads:[~2025-01-03 16:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 10:04 [PATCH v7 0/2] selftests: tmpfs: Add kselftest support Shivam Chaudhary
2025-01-02 10:04 ` [PATCH v7 1/2] selftests: tmpfs: Add Test-skip if not run as root Shivam Chaudhary
2025-01-02 21:54   ` Shuah Khan
2025-01-03 16:36     ` Shivam Chaudhary [this message]
2025-01-03 16:52       ` Shuah Khan
2025-01-02 10:04 ` [PATCH v7 2/2] selftests: tmpfs: Add kselftest support to tmpfs Shivam Chaudhary
2025-01-02 21:10   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5bf80c4-0062-4f3d-94e2-a40c1cac2934@gmail.com \
    --to=cvam0000@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox