From: Shuah Khan <skhan@linuxfoundation.org>
To: Shivam Chaudhary <cvam0000@gmail.com>, shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v7 1/2] selftests: tmpfs: Add Test-skip if not run as root
Date: Thu, 2 Jan 2025 14:54:14 -0700 [thread overview]
Message-ID: <e6d8cb36-089b-41cc-8ab7-90338bcda8de@linuxfoundation.org> (raw)
In-Reply-To: <20250102100459.1291426-2-cvam0000@gmail.com>
On 1/2/25 03:04, Shivam Chaudhary wrote:
> Add 'ksft_exit_skip()', if not run as root, with an appropriate
> Warning.
>
> Add 'ksft_print_header()' and 'ksft_set_plan()' to structure test
> outputs more effectively.
>
> Test logs:
>
> Before Change:
> - Without root
> error: unshare, errno 1
>
> - With root
> No, output
>
> After change:
>
> - Without root
> TAP version 13
> 1..1
> ok 2 # SKIP This test needs root to run!
> Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
>
> - With root
> TAP version 13
> 1..1
How are you running this test to see the before ad after
results?
thanks,
-- Shuah
next prev parent reply other threads:[~2025-01-02 21:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 10:04 [PATCH v7 0/2] selftests: tmpfs: Add kselftest support Shivam Chaudhary
2025-01-02 10:04 ` [PATCH v7 1/2] selftests: tmpfs: Add Test-skip if not run as root Shivam Chaudhary
2025-01-02 21:54 ` Shuah Khan [this message]
2025-01-03 16:36 ` Shivam Chaudhary
2025-01-03 16:52 ` Shuah Khan
2025-01-02 10:04 ` [PATCH v7 2/2] selftests: tmpfs: Add kselftest support to tmpfs Shivam Chaudhary
2025-01-02 21:10 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6d8cb36-089b-41cc-8ab7-90338bcda8de@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=cvam0000@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox