From: Shuah Khan <skhan@linuxfoundation.org>
To: Gautam Menghani <gautammenghani201@gmail.com>,
shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] kselftests/ir : Improve readability of modprobe error message
Date: Mon, 16 May 2022 13:48:01 -0600 [thread overview]
Message-ID: <a763b159-0072-b883-5e47-65f86bec66dd@linuxfoundation.org> (raw)
In-Reply-To: <20220513190721.16482-1-gautammenghani201@gmail.com>
On 5/13/22 1:07 PM, Gautam Menghani wrote:
> Improve the readability of error message which says module not found.
> The new behaviour is consistent with the modprobe command.
>
> Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
> ---
> tools/testing/selftests/ir/ir_loopback.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ir/ir_loopback.sh b/tools/testing/selftests/ir/ir_loopback.sh
> index b90dc9939f45..aff9299c9416 100755
> --- a/tools/testing/selftests/ir/ir_loopback.sh
> +++ b/tools/testing/selftests/ir/ir_loopback.sh
> @@ -10,7 +10,7 @@ if [ $UID != 0 ]; then
> fi
>
> if ! /sbin/modprobe -q -n rc-loopback; then
> - echo "ir_loopback: module rc-loopback is not found [SKIP]"
> + echo "ir_loopback: module rc-loopback is not found in /lib/modules/`uname -r` [SKIP]"
> exit $ksft_skip
> fi
>
>
Applied to linux-kselftest next for 5.19-rc1
thanks,
-- Shuah
prev parent reply other threads:[~2022-05-16 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 19:07 [PATCH] kselftests/ir : Improve readability of modprobe error message Gautam Menghani
2022-05-16 19:48 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a763b159-0072-b883-5e47-65f86bec66dd@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=gautammenghani201@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox