* [PATCH] kselftests/ir : Improve readability of modprobe error message
@ 2022-05-13 19:07 Gautam Menghani
2022-05-16 19:48 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Gautam Menghani @ 2022-05-13 19:07 UTC (permalink / raw)
To: shuah, linux-kselftest; +Cc: Gautam Menghani, linux-kernel
Improve the readability of error message which says module not found.
The new behaviour is consistent with the modprobe command.
Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
---
tools/testing/selftests/ir/ir_loopback.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ir/ir_loopback.sh b/tools/testing/selftests/ir/ir_loopback.sh
index b90dc9939f45..aff9299c9416 100755
--- a/tools/testing/selftests/ir/ir_loopback.sh
+++ b/tools/testing/selftests/ir/ir_loopback.sh
@@ -10,7 +10,7 @@ if [ $UID != 0 ]; then
fi
if ! /sbin/modprobe -q -n rc-loopback; then
- echo "ir_loopback: module rc-loopback is not found [SKIP]"
+ echo "ir_loopback: module rc-loopback is not found in /lib/modules/`uname -r` [SKIP]"
exit $ksft_skip
fi
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kselftests/ir : Improve readability of modprobe error message
2022-05-13 19:07 [PATCH] kselftests/ir : Improve readability of modprobe error message Gautam Menghani
@ 2022-05-16 19:48 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2022-05-16 19:48 UTC (permalink / raw)
To: Gautam Menghani, shuah, linux-kselftest; +Cc: linux-kernel, Shuah Khan
On 5/13/22 1:07 PM, Gautam Menghani wrote:
> Improve the readability of error message which says module not found.
> The new behaviour is consistent with the modprobe command.
>
> Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
> ---
> tools/testing/selftests/ir/ir_loopback.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ir/ir_loopback.sh b/tools/testing/selftests/ir/ir_loopback.sh
> index b90dc9939f45..aff9299c9416 100755
> --- a/tools/testing/selftests/ir/ir_loopback.sh
> +++ b/tools/testing/selftests/ir/ir_loopback.sh
> @@ -10,7 +10,7 @@ if [ $UID != 0 ]; then
> fi
>
> if ! /sbin/modprobe -q -n rc-loopback; then
> - echo "ir_loopback: module rc-loopback is not found [SKIP]"
> + echo "ir_loopback: module rc-loopback is not found in /lib/modules/`uname -r` [SKIP]"
> exit $ksft_skip
> fi
>
>
Applied to linux-kselftest next for 5.19-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-13 19:07 [PATCH] kselftests/ir : Improve readability of modprobe error message Gautam Menghani
2022-05-16 19:48 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox